Header only #37
Merged
Header only #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a user to specify they want header only with the macro DOCOPT_HEADER_ONLY. docopt.h will include docopt.cpp as inline functions.
Allow a user to specify they want header only with the macro DOCOPT_HEADER_ONLY. docopt.h will include docopt.cpp as inline functions.
… that functions were showing up in the public symboltable. To remove that, I would mark them as inline, but then I figured I would put the functions closer to the class name.
|
Well, this may require changes to CMakeLists.txt. After the maintainer merges this PR I will write a fix for CMake build. |
|
Travis seems ok, so I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to make docopt.cpp header only.
A user would define the preprocessor macro DOCOPT_HEADER_ONLY to control this behavior. This cause the cpp file to be included with the header file.
I've moved most of the inline functions out of docopt.cpp to docopt_private.h as I was making them inline to remove them from the symbol table in Header only mode, so I thought it would be best to put them closer to the functions.
I've tested by building with clang on Mac, and I see a small change in the size of the lib (<1 kbyte smaller).