8000 Remove s390x from Alpine variants on 3.14(+) by tianon · Pull Request #1015 · docker-library/python · GitHub
[go: up one dir, main page]
Skip to content

Remove s390x from Alpine variants on 3.14(+) #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Remove s390x from Alpine variants on 3.14(+) #1015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions generate-stackbrew-library.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,22 +136,24 @@ for version; do
;;
esac

# https://github.com/docker-library/python/pull/931 (riscv64 builds on 3.11+ take way too long 😞)
case "$version" in
3.9 | 3.10) ;;
*) variantArches="$(sed <<<" $variantArches " -e 's/ riscv64 / /g')" ;;
esac

# https://github.com/python/cpython/issues/93619 (Linking error when building 3.11 beta on mips64le) + https://peps.python.org/pep-0011/ (mips is not even tier 3)
case "$version" in
3.9) ;;
*)
if [ "$version" != '3.10' ]; then
# https://github.com/docker-library/python/pull/931
variantArches="$(sed <<<" $variantArches " -e 's/ riscv64 / /g')"
fi
# https://github.com/python/cpython/issues/93619 + https://peps.python.org/pep-0011/
variantArches="$(sed <<<" $variantArches " -e 's/ mips64le / /g')"
;;
*) variantArches="$(sed <<<" $variantArches " -e 's/ mips64le / /g')" ;;
esac

if [ "$fullVersion" = '3.14.0a1' ]; then
# https://github.com/python/cpython/issues/125535 - 3.14.0a1 fails to build on i386
# https://github.com/python/cpython/pull/125244 (already fixed for the next release)
variantArches="$(sed <<<" $variantArches " -e 's/ i386 / /g')"
Comment on lines -151 to -154
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also straight up dead code. 😄

# https://github.com/docker-library/python/issues/1014 (ensurepip failing on s390x 3.14.0a6 Alpine images)
if [[ "$variant" == alpine* ]]; then
case "$version" in
3.9 | 3.10 | 3.11 | 3.12 | 3.13) ;;
*) variantArches="$(sed <<<" $variantArches " -e 's/ s390x / /g')" ;;
esac
fi

sharedTags=()
Expand Down
Loading
0