Use anchor instead of building toString() for debug logging (#2035)

belugabehr · web-flow · commit a1243d6493ed · 2023-06-19T08:49:44.000-06:00
diff --git a/docker-java-api/src/main/java/com/github/dockerjava/api/command/BuildImageResultCallback.java b/docker-java-api/src/main/java/com/github/dockerjava/api/command/BuildImageResultCallback.java
@@ -31,7 +31,7 @@ public void onNext(BuildResponseItem item) {
         } else if (item.isErrorIndicated()) {
             this.error = item.getError();
         }
-        LOGGER.debug(item.toString());
+        LOGGER.debug("{}", item);
     }
 
     /**
diff --git a/docker-java-api/src/main/java/com/github/dockerjava/api/command/LoadImageCallback.java b/docker-java-api/src/main/java/com/github/dockerjava/api/command/LoadImageCallback.java
@@ -22,7 +22,7 @@ public void onNext(LoadResponseItem item) {
             this.error = item.getError();
         }
 
-        LOGGER.debug(item.toString());
+        LOGGER.debug("{}", item);
     }
 
     public String awaitMessage() {
diff --git a/docker-java-api/src/main/java/com/github/dockerjava/api/command/PullImageResultCallback.java b/docker-java-api/src/main/java/com/github/dockerjava/api/command/PullImageResultCallback.java
@@ -41,7 +41,7 @@ public void onNext(PullResponseItem item) {
             handleDockerClientResponse(item);
         }
 
-        LOGGER.debug(item.toString());
+        LOGGER.debug("{}", item);
     }
 
     private void checkForDockerSwarmResponse(PullResponseItem item) {
diff --git a/docker-java-api/src/main/java/com/github/dockerjava/api/command/WaitContainerResultCallback.java b/docker-java-api/src/main/java/com/github/dockerjava/api/command/WaitContainerResultCallback.java
@@ -27,7 +27,7 @@ public class WaitContainerResultCallback extends ResultCallbackTemplate<WaitCont
     @Override
     public void onNext(WaitResponse waitResponse) {
         this.waitResponse = waitResponse;
-        LOGGER.debug(waitResponse.toString());
+        LOGGER.debug("{}", waitResponse);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public void onNext(BuildResponseItem item) {`
`31`	`31`	`} else if (item.isErrorIndicated()) {`
`32`	`32`	`this.error = item.getError();`
`33`	`33`	`}`
`34`		`- LOGGER.debug(item.toString());`
	`34`	`+ LOGGER.debug("{}", item);`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public void onNext(LoadResponseItem item) {`
`22`	`22`	`this.error = item.getError();`
`23`	`23`	`}`
`24`	`24`
`25`		`- LOGGER.debug(item.toString());`
	`25`	`+ LOGGER.debug("{}", item);`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`public String awaitMessage() {`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public void onNext(PullResponseItem item) {`
`41`	`41`	`handleDockerClientResponse(item);`
`42`	`42`	`}`
`43`	`43`
`44`		`- LOGGER.debug(item.toString());`
	`44`	`+ LOGGER.debug("{}", item);`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`private void checkForDockerSwarmResponse(PullResponseItem item) {`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public class WaitContainerResultCallback extends ResultCallbackTemplate<WaitCont`
`27`	`27`	`@Override`
`28`	`28`	`public void onNext(WaitResponse waitResponse) {`
`29`	`29`	`this.waitResponse = waitResponse;`
`30`		`- LOGGER.debug(waitResponse.toString());`
	`30`	`+ LOGGER.debug("{}", waitResponse);`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`/**`