Don't swallow IOException caused by opening socket (#2041)

Sineaggi · web-flow · commit 721f09f4bf72 · 2024-12-11T13:02:20.000-06:00
Add additional context to socket exception
diff --git a/docker-java-transport-okhttp/src/main/java/com/github/dockerjava/okhttp/UnixSocketFactory.java b/docker-java-transport-okhttp/src/main/java/com/github/dockerjava/okhttp/UnixSocketFactory.java
@@ -20,7 +20,7 @@ public Socket createSocket() {
         try {
             return UnixSocket.get(socketPath);
         } catch (IOException e) {
-            throw new RuntimeException(e);
+            throw new RuntimeException("Failed create socket with path " + socketPath, e);
         }
     }
 
diff --git a/docker-java-transport/src/main/java/com/github/dockerjava/transport/UnixSocket.java b/docker-java-transport/src/main/java/com/github/dockerjava/transport/UnixSocket.java
@@ -3,6 +3,7 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
+import java.lang.reflect.InvocationTargetException;
 import java.net.Socket;
 import java.net.SocketAddress;
 import java.net.SocketException;
@@ -24,7 +25,8 @@ public class UnixSocket extends AbstractSocket {
     public static Socket get(String path) throws IOException {
         try {
             return new UnixSocket(path);
-        } catch (Exception e) {
+        } catch (ClassNotFoundException | NoSuchMethodException | InvocationTargetException |
+                 IllegalAccessException e) {
             //noinspection deprecation
             return DomainSocket.get(path);
         }
@@ -34,7 +36,8 @@ public static Socket get(String path) throws IOException {
 
     private final SocketChannel socketChannel;
 
-    private UnixSocket(String path) throws Exception {
+    private UnixSocket(String path) throws ClassNotFoundException, NoSuchMethodException, InvocationTargetException,
+        IllegalAccessException, IOException {
         Class<?> unixDomainSocketAddress = Class.forName("java.net.UnixDomainSocketAddress");
         this.socketAddress =
             (SocketAddress) unixDomainSocketAddress.getMethod("of", String.class)

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public Socket createSocket() {`
`20`	`20`	`try {`
`21`	`21`	`return UnixSocket.get(socketPath);`
`22`	`22`	`} catch (IOException e) {`
`23`		`- throw new RuntimeException(e);`
	`23`	`+ throw new RuntimeException("Failed create socket with path " + socketPath, e);`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`