8000 networkdb: Use write lock in handleNodeEvent by cpuguy83 · Pull Request #2136 · moby/libnetwork · GitHub
[go: up one dir, main page]
Skip to content

networkdb: Use write lock in handleNodeEvent #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mavenugo merged 1 commit into from
Apr 12, 2018
Merged

networkdb: Use write lock in handleNodeEvent #2136

mavenugo merged 1 commit into from
Apr 12, 2018

Conversation

@cpuguy83
Copy link
Member
@cpuguy83 cpuguy83 commented Apr 12, 2018 •
edited
Loading

handleNodeEvent is calling changeNodeState which writes to various
maps on the ndb object.
Using a write lock prevents a panic on concurrent read/write access on
these maps.

Related to moby/moby#36814

@cpuguy83
networkdb: Use write lock in handleNodeEvent
48b3773 
`handleNodeEvent` is calling `changeNodeState` which writes to various
maps on the ndb object.
Using a write lock prevents a panic on concurrent read/write access on
these maps.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
fcrisciani
fcrisciani approved these changes Apr 12, 2018
View reviewed changes
Copy link
@fcrisciani fcrisciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
8000
Copy link
codecov-io commented Apr 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6d13832). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2136   +/-   ##
=========================================
  Coverage          ?   40.46%           
=========================================
  Files             ?      139           
  Lines             ?    22472           
  Branches          ?        0           
=========================================
  Hits              ?     9093           
  Misses            ?    12040           
  Partials          ?     1339
Impacted Files Coverage Δ
networkdb/delegate.go 74.35% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d13832...48b3773. Read the comment docs.

ddebroy
ddebroy approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor
@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mavenugo mavenugo merged commit c15b372 into moby:master Apr 12, 2018
@cpuguy83 cpuguy83 deleted the fix_map_access_panic_ndb branch April 12, 2018 03:32
@cpuguy83 cpuguy83 mentioned this pull request Apr 14, 2018
Merged
@thaJeztah thaJeztah mentioned this pull request Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@fcrisciani fcrisciani fcrisciani approved these changes

@mavenugo mavenugo mavenugo approved these changes

@ddebroy ddebroy ddebroy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cpuguy83 @codecov-io @fcrisciani @mavenugo @ddebroy
0