8000 Merge pull request #1074 from crazy-max/build-cmd-debug · docker/build-push-action@af5a7ed · GitHub
[go: up one dir, main page]
Skip to content

Commit af5a7ed

Browse files
crazy-maxcrazy-max
authored
Merge pull request #1074 from crazy-max/build-cmd-debug
disable quotes detection for "outputs" input
2 parents 00ae31a + 2a85189 commit af5a7ed

File tree

5 files changed

+30
-3
lines changed

5 files changed

+30
-3
lines changed

‎__tests__/context.test.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -705,6 +705,26 @@ ANOTHER_SECRET=ANOTHER_SECRET_ENV`]
705705
'--metadata-file', path.join(tmpDir, 'metadata-file'),
706706
'.'
707707
]
708+
],
709+
[
710+
29,
711+
'0.12.0',
712+
new Map<string, string>([
713+
['context', '.'],
714+
['outputs', `type=image,"name=localhost:5000/name/app:latest,localhost:5000/name/app:foo",push-by-digest=true,name-canonical=true,push=true`],
715+
['load', 'false'],
716+
['no-cache', 'false'],
717+
['push', 'false'],
718+
['pull', 'false'],
719+
]),
720+
[
721+
'build',
722+
'--iidfile', path.join(tmpDir, 'iidfile'),
723+
"--output", `type=image,"name=localhost:5000/name/app:latest,localhost:5000/name/app:foo",push-by-digest=true,name-canonical=true,push=true`,
724+
"--provenance", `mode=min,inline-only=true,builder-id=https://github.com/docker/build-push-action/actions/runs/123456789`,
725+
'--metadata-file', path.join(tmpDir, 'metadata-file'),
726+
'.'
727+
]
708728
]
709729
])(
710730
'[%d] given %p with %p as inputs, returns %p',

‎dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/context.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export async function getInputs(): Promise<Inputs> {
6060
network: core.getInput('network'),
6161
noCache: core.getBooleanInput('no-cache'),
6262
noCacheFilters: Util.getInputList('no-cache-filters'),
63-
outputs: Util.getInputList('outputs', {ignoreComma: true}),
63+
outputs: Util.getInputList('outputs', {ignoreComma: true, quote: false}),
6464
platforms: Util.getInputList('platforms'),
6565
provenance: BuildxInputs.getProvenanceInput('provenance'),
6666
pull: core.getBooleanInput('pull'),

‎src/main.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ actionsToolkit.run(
1717
// main
1818
async () => {
1919
const inputs: context.Inputs = await context.getInputs();
20+
core.debug(`inputs: ${JSON.stringify(inputs)}`);
21+
2022
const toolkit = new Toolkit();
2123

2224
await core.group(`GitHub Actions runtime token ACs`, async () => {
@@ -73,7 +75,12 @@ actionsToolkit.run(
7375
});
7476

7577
const args: string[] = await context.getArgs(inputs, toolkit);
78+
core.debug(`context.getArgs: ${JSON.stringify(args)}`);
79+
7680
const buildCmd = await toolkit.buildx.getCommand(args);
81+
core.debug(`buildCmd.command: ${buildCmd.command}`);
82+
core.debug(`buildCmd.args: ${JSON.stringify(buildCmd.args)}`);
83+
7784
await Exec.getExecOutput(buildCmd.command, buildCmd.args, {
7885
ignoreReturnCode: true
7986
}).then(res => {

0 commit comments

Comments
 (0)
0