8000 feat: support python 3.7 by samsja · Pull Request #1055 · docarray/docarray · GitHub
[go: up one dir, main page]
Skip to content

feat: support python 3.7 #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 6 commits into from
Jan 26, 2023
Merged

feat: support python 3.7 #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4f053b1
feat: add python 3.7 support
samsja Jan 26, 2023
39a8005
feat: remove get args
samsja Jan 26, 2023
da11139
fix: fix
samsja Jan 26, 2023
52406a2
fix: fix
samsja Jan 26, 2023
d5d6f5f
chore(ci): bump ci
samsja Jan 26, 2023
20c6b9c
Merge branch 'feat-rewrite-v2' into feat-support-37
samsja Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.5.0
- name: Set up Python 3.8
- name: Set up Python 3.7
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.7
- name: Lint with ruff
run: |
python -m pip install --upgrade pip
Expand All @@ -32,10 +32,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.5.0
- name: Set up Python 3.8
- name: Set up Python 3.7
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.7
- name: check black
run: |
python -m pip install --upgrade pip
Expand All @@ -50,10 +50,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.5.0
- name: Set up Python 3.8
- name: Set up Python 3.7
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.7
- name: Prepare enviroment
run: |
python -m pip install --upgrade pip
Expand All @@ -67,10 +67,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.5.0
- name: Set up Python 3.8
- name: Set up Python 3.7
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.7
- name: check mypy
run: |
python -m pip install --upgrade pip
Expand All @@ -97,7 +97,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.8]
python-version: [3.7]
# test-path: ${{fromJson(needs.prep-testbed.outputs.matrix)}}
test-path: [tests/integrations, tests/units]
steps:
Expand Down Expand Up @@ -126,7 +126,7 @@ jobs:
# files: "coverage.xml"
# - name: Upload coverage from test to Codecov
# uses: codecov/codecov-action@v3.1.1
# if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.8'
# if: steps.check_files.outputs.files_exists == 'true' && ${{ matrix.python-version }} == '3.7'
# with:
# file: coverage.xml
# flags: ${{ steps.test.outputs.codecov_flag }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_only_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
ref: ${{ env.BRANCH_NAME }}
- uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.7
- uses: actions/setup-node@v2
with:
node-version: '14'
Expand Down
4 changes: 2 additions & 2 deletions docarray/utils/_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Any, get_args
from typing import Any

from typing_inspect import is_union_type
from typing_inspect import get_args, is_union_type

from docarray.typing.tensor.abstract_tensor import AbstractTensor

Expand Down
Loading
0