8000 fix: Allow frontend editing of page title fields (#8131) (#8132) · django-cms/django-cms@d8794b1 · GitHub
[go: up one dir, main page]

Skip to content

Commit d8794b1

Browse files
authored
fix: Allow frontend editing of page title fields (#8131) (#8132)
* fix: Placeholder page getter failed for unpublished pages (#8115) * Fix: Placeholder page getter fails for unpublished pages * Update cms/models/placeholdermodel.py * Update cms/models/placeholdermodel.py * fix: Allow frontend editing of page title fields (#8131)
1 parent 4090b1b commit d8794b1

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

cms/admin/pageadmin.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ class PageAdmin(admin.ModelAdmin):
103103
copy_form = CopyPageForm
104104
move_form = MovePageForm
105105
inlines = PERMISSION_ADMIN_INLINES
106+
title_frontend_editable_fields = ['title', 'menu_title', 'page_title']
106107

107108
def has_add_permission(self, request):
108109
return False

cms/tests/test_admin.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
URL_CMS_PAGE_PUBLISHED,
2727
CMSTestCase,
2828
)
29-
from cms.utils.compat import DJANGO_2_2
29+
from cms.utils.compat import DJANGO_2_2, DJANGO_4_2
3030
from cms.utils.conf import get_cms_setting
3131
from cms.utils.i18n import get_language_list
3232
from cms.utils.urlutils import admin_reverse
@@ -461,6 +461,15 @@ def test_too_many_plugins_type(self):
461461
response = self.client.post(url, data)
462462
self.assertEqual(response.status_code, HttpResponseBadRequest.status_code)
463463

464+
def test_page_edit_field_endpoint(self):
465+
endpoint = admin_reverse("cms_page_edit_title_fields", args=(self.page.pk, "en")) + "?language=en&edit_fields=page_title"
466+
with self.login_user_context(self.get_superuser()):
467+
response = self.client.get(endpoint)
468+
if DJANGO_4_2:
469+
self.assertContains(response, '<input type="text" name="page_title" maxlength="255" id="id_page_title">')
470+
else:
471+
self.assertContains(response, '<input type="text" name="page_title" maxlength="255" aria-describedby="id_page_title_helptext" id="id_page_title">')
472+
464473

465474
class NoDBAdminTests(CMSTestCase):
466475
@property

0 commit comments

Comments
 (0)
0