fix: removed deprecated JavaScript in cms.modal.js (#8192)

jrief · web-flow · commit 71d94bed47b5 · 2025-03-31T08:01:48.000+02:00
* removes some deprecated JavaScript in cms.modal.js

* fix gulp-lint anotation
diff --git a/cms/static/cms/js/modules/cms.modal.js b/cms/static/cms/js/modules/cms.modal.js
@@ -777,29 +777,28 @@ class Modal {
 
                 if (item.is('input') || item.is('button')) {
                     that.ui.modalBody.addClass('cms-loader');
-                    var frm = item.closest('form');
+                    var frm = item[0].form;
 
                     // In Firefox with 1Password extension installed (FF 45 1password 4.5.6 at least)
                     // the item[0].click() doesn't work, which notably breaks
                     // deletion of the plugin. Workaround is that if the clicked button
                     // is the only button in the form - submit a form, otherwise
                     // click on the button
-                    if (frm.find('button, input[type="button"], input[type="submit"]').length > 1) {
+                    if (frm.querySelectorAll('button, input[type="button"], input[type="submit"]').length > 1) {
                         // we need to use native `.click()` event specifically
                         // as we are inside an iframe and magic is happening
                         item[0].click();
                     } else {
                         // have to dispatch native submit event so all the submit handlers
                         // can be fired, see #5590
-                        var evt = document.createEvent('HTMLEvents');
+                        var evt = new CustomEvent('submit', { bubbles: false, cancelable: true });
 
-                        evt.initEvent('submit', false, true);
-                        if (frm[0].dispatchEvent(evt)) {
+                        if (frm.dispatchEvent(evt)) {
                             // triggering submit event in webkit based browsers won't
                             // actually submit the form, while in Gecko-based ones it
                             // will and calling frm.submit() would throw NS_ERROR_UNEXPECTED
                             try {
-                                frm[0].submit();
+                                frm.submit();
                             } catch (err) {}
                         }
                     }
