10000 fix: return _handle_no_page when page is None · django-cms/django-cms@3e15922 · GitHub
[go: up one dir, main page]

Skip to content

Commit 3e15922

Browse files
committed
fix: return _handle_no_page when page is None
1 parent ed7e206 commit 3e15922

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

cms/tests/test_views.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,14 @@ def test_handle_no_page_for_root_url(self):
7474
self.assertEqual(response.status_code, 302)
7575
self.assertEqual(response.url, reverse('admin:cms_pagecontent_changelist'))
7676

77+
def test_handle_no_page_for_rool_url_no_homepage(self):
78+
"""
79+
Test details view when visiting root and homepage doesn't exist
80+
"""
81+
create_page("one", "nav_playground.html", "en")
82+
response = self.client.get("/en/")
83+
self.assertEqual(response.status_code, 302)
84+
7785
def test_apphook_not_hooked(self):
7886
"""
7987
Test details view when apphook pool has apphooks, but they're not

cms/views.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,10 @@ def details(request, slug):
115115
return HttpResponseRedirect(redirect_url)
116116

117117
if not page:
118-
# raise 404
119-
_handle_no_page(request)
118+
# raise 404 or redirect to PageContent's
119+
# changelist in the admin if this is a
120+
# request to the root URL
121+
return _handle_no_page(request)
120122

121123
request.current_page = page
122124

0 commit comments

Comments
 (0)
0