Refs #31286 -- Default to running checks against all databases. #19912
+20
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b8402f to
2f4ccfa
Compare
charettes
commented
Sep 29, 2025
| ) | ||
| else: | ||
| base_checks = self.base_field.check() | ||
| base_checks = self.base_field.check(**kwargs) |
There was a problem hiding this comment.
This is not strictly necessary here but it ensures databases is respected when specified.
Regression in 0b83c8c which added support for running checks only against databases but also defaulted to running against no databases if not specified. Thanks Tim Graham for surfacing how this was a problematic default.
2f4ccfa to
d9e4abc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression in 0b83c8c which added support for running checks only against databases but also defaulted to running against no databases if not specified.
Thanks Tim Graham for surfacing how this was a problematic default.