10000 chore: cleanup SidebarNav, SidebarNavLink · digital-codes/coreui-vue@06a0f01 · GitHub
[go: up one dir, main page]
Skip to content

Commit 06a0f01

Browse files
xidedixxidedix
committed
chore: cleanup SidebarNav, SidebarNavLink
1 parent 3788ff8 commit 06a0f01

File tree

2 files changed

+15
-21
lines changed

2 files changed

+15
-21
lines changed

‎src/components/Sidebar/SidebarNav.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
<!-- Second level dropdown -->
2222
<SidebarNavDropdown :key="index1" :name="childL1.name" :url="childL1.url" :icon="childL1.icon">
2323
<li :key="index2" class="nav-item" v-for="(childL2, index2) in childL1.children">
24-
<SidebarNavLink :name="childL2.name" :url="childL2.url" :icon="childL2.icon" :badge="childL2.badge" :variant="item.variant" :attributes="item.attributes" />
24+
<SidebarNavLink :name="childL2.name" :url="childL2.url" :icon="childL2.icon" :badge="childL2.badge" :variant="childL2.variant< 10000 span class="pl-pds">" :attributes="childL2.attributes" />
2525
</li>
2626
</SidebarNavDropdown>
2727
</template>
2828
<template v-else>
2929
<SidebarNavItem :key="index1" :classes="item.class">
30-
<SidebarNavLink :name="childL1.name" :url="childL1.url" :icon="childL1.icon" :badge="childL1.badge" :variant="item.variant" :attributes="item.attributes"/>
30+
<SidebarNavLink :name="childL1.name" :url="childL1.url" :icon="childL1.icon" :badge="childL1.badge" :variant="childL1.variant" :attributes="childL1.attributes"/>
3131
</SidebarNavItem>
3232
</template>
3333
</template>

‎src/components/Sidebar/SidebarNavLink.vue

Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,16 @@
11
<template>
2-
<div v-if="isDisabled">
3-
<a href :class="classList" v-bind="attributes" tabindex="-1">
4-
<i :class="classIcon"></i> {{name}}
5-
<b-badge v-if="badge && badge.text" :variant="badge.variant">{{badge.text}}</b-badge>
6-
</a>
7-
</div>
8-
<div v-else-if="isExternalLink">
9-
<a :href="url" :class="classList" v-bind="attributes">
10-
<i :class="classIcon"></i> {{name}}
11-
<b-badge v-if="badge && badge.text" :variant="badge.variant">{{badge.text}}</b-badge>
12-
</a>
13-
</div>
14-
<div v-else>
15-
<router-link :to="url" :class="classList" v-bind="attributes">
16-
<i :class="classIcon"></i> {{name}}
17-
<b-badge v-if="badge && badge.text" :variant="badge.variant">{{badge.text}}</b-badge>
18-
</router-link>
19-
</div>
2+
<a :class="classList" v-bind="attributes" tabindex="-1" v-on:click.stop.prevent v-if="isDisabled">
3+
<i :class="classIcon"></i> <span>{{name}}</span>
4+
<b-badge v-if="badge && badge.text" :variant="badge.variant">{{badge.text}}</b-badge>
5+
</a>
6+
<a :href="url" :class="classList" v-bind="attributes" v-else-if="isExternalLink">
7+
<i :class="classIcon"></i> {{name}}
8+
<b-badge v-if="badge && badge.text" :variant="badge.variant">{{badge.text}}</b-badge>
9+
</a>
10+
<router-link :to="url" :class="classList" v-bind="attributes" v-else>
11+
<i :class="classIcon"></i> {{name}}
12+
<b-badge v-if="badge && badge.text" :variant="badge.variant">{{badge.text}}</b-badge>
13+
</router-link>
2014
</template>
2115

2216
<script>
@@ -78,7 +72,7 @@ export default {
7872
return this.getClassArray(this.attributes.class)
7973
},
8074
disabledClasses () {
81-
return this.isDisabled ? 'disabled btn-link'.split(' ') : []
75+
return this.isDisabled ? 'disabled'.split(' ') : []
8276
},
8377
isDisabled () {
8478
return Boolean(this.attributes.disabled)

0 commit comments

Comments
 (0)
0