feat: include API response headers in 'Last Response' (twilio#528)

childish-sambino · web-flow · commit 203072ba6416 · 2020-06-29T14:09:55.000-05:00
The default HTTP client stores 'Last Request' and 'Last Response' information for access to more data about the raw API request/response. The response object did not contain the headers until now.
diff --git a/twilio/http/http_client.py b/twilio/http/http_client.py
@@ -1,11 +1,11 @@
+import logging
+
 from requests import Request, Session, hooks
 from requests.adapters import HTTPAdapter
-
+from twilio.compat import urlencode
 from twilio.http import HttpClient
-from twilio.http.response import Response
 from twilio.http.request import Request as TwilioRequest
-import logging
-from twilio.compat import urlencode
+from twilio.http.response import Response
 
 _logger = logging.getLogger('twilio.http_client')
 
@@ -14,7 +14,9 @@ class TwilioHttpClient(HttpClient):
     """
     General purpose HTTP Client for interacting with the Twilio API
     """
-    def __init__(self, pool_connections=True, request_hooks=None, timeout=None, logger=_logger, proxy=None, max_retries=None):
+
+    def __init__(self, pool_connections=True, request_hooks=None, timeout=None, logger=_logger, proxy=None,
+                 max_retries=None):
         """
         Constructor for the TwilioHttpClient
 
@@ -96,6 +98,6 @@ def request(self, method, url, params=None, data=None, headers=None, auth=None,
             method=method, status=response.status_code, text=response.text)
         )
 
-        self.last_response = Response(int(response.status_code), response.text)
+        self.last_response = Response(int(response.status_code), response.text, response.headers)
 
         return self.last_response
diff --git a/twilio/http/response.py b/twilio/http/response.py
@@ -1,9 +1,7 @@
 class Response(object):
-    """
-
-    """
-    def __init__(self, status_code, text):
+    def __init__(self, status_code, text, headers=None):
         self.content = text
+        self.headers = headers
         self.cached = False
         self.status_code = status_code
         self.ok = self.status_code < 400
