E5FE minor #58497 [DependencyInjection] Sort PassConfig:TYPE_* by order of… · devloop42/symfony@c16abbf · GitHub
[go: up one dir, main page]

Skip to content

Commit c16abbf

Browse files
minor symfony#58497 [DependencyInjection] Sort PassConfig:TYPE_* by order of execution (lyrixx)
This PR was merged into the 7.2 branch. Discussion ---------- [DependencyInjection] Sort PassConfig:TYPE_* by order of execution | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT I wanted to do this PR for ages. Finally took time to do it! --- IMHO, it's easier to read the constants, and understand right away when the pass is executed Commits ------- c736db4 [DependencyInjection] Sort PassConfig:TYPE_* by order of execution
2 parents f57a6de + c736db4 commit c16abbf

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/Symfony/Component/DependencyInjection/Compiler/PassConfig.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,12 @@
2222
*/
2323
class PassConfig
2424
{
25-
public const TYPE_AFTER_REMOVING = 'afterRemoving';
25+
// In the order of execution
2626
public const TYPE_BEFORE_OPTIMIZATION = 'beforeOptimization';
27-
public const TYPE_BEFORE_REMOVING = 'beforeRemoving';
2827
public const TYPE_OPTIMIZE = 'optimization';
28+
public const TYPE_BEFORE_REMOVING = 'beforeRemoving';
2929
public const TYPE_REMOVE = 'removing';
30+
public const TYPE_AFTER_REMOVING = 'afterRemoving';
3031

3132
private MergeExtensionConfigurationPass $mergePass;
3233
private array $afterRemovingPasses;

0 commit comments

Comments
 (0)
0