[DoctrineBridge] Fix risky test warnings

alexandre-daubois · alexandre-daubois · commit 41327bdf2c23 · 2024-10-01T12:57:16.000+02:00
diff --git a/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypePerformanceTest.php b/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypePerformanceTest.php
@@ -24,7 +24,7 @@
  */
 class EntityTypePerformanceTest extends FormPerformanceTestCase
 {
-    private const ENTITY_CLASS = 'Symfony\Bridge\Doctrine\Tests\Fixtures\SingleIntIdEntity';
+    private const ENTITY_CLASS = SingleIntIdEntity::class;
 
     /**
      * @var \Doctrine\ORM\EntityManager
diff --git a/src/Symfony/Component/Form/Test/FormPerformanceTestCase.php b/src/Symfony/Component/Form/Test/FormPerformanceTestCase.php
@@ -45,6 +45,8 @@ private function doRunTest()
             $this->fail(sprintf('expected running time: <= %s but was: %s', $this->maxRunningTime, $time));
         }
 
+        $this->expectNotToPerformAssertions();
+
         return $result;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@`
`24`	`24`	`*/`
`25`	`25`	`class EntityTypePerformanceTest extends FormPerformanceTestCase`
`26`	`26`	`{`
`27`		`- private const ENTITY_CLASS = 'Symfony\Bridge\Doctrine\Tests\Fixtures\SingleIntIdEntity';`
	`27`	`+ private const ENTITY_CLASS = SingleIntIdEntity::class;`
`28`	`28`
`29`	`29`	`/**`
`30`	`30`	`* @var \Doctrine\ORM\EntityManager`
Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,8 @@ private function doRunTest()`
`45`	`45`	`$this->fail(sprintf('expected running time: <= %s but was: %s', $this->maxRunningTime, $time));`
`46`	`46`	`}`
`47`	`47`
	`48`	`+ $this->expectNotToPerformAssertions();`
	`49`	`+`
`48`	`50`	`return $result;`
`49`	`51`	`}`
`50`	`52`