opendrive: re-read hash when updating objects

ncw · ncw · commit c47a4c970307 · 2018-06-15T14:50:17.000+01:00
Previously this was reading a stale hash from the object leading to
broken integration tests.

This fixes these integration tests TestSyncDoesntUpdateModtime,
TestSyncAfterChangingFilesSizeOnly, TestSyncAfterChangingContentsOnly,
TestSyncWithUpdateOlder, TestSyncUTFNorm.
diff --git a/backend/opendrive/opendrive.go b/backend/opendrive/opendrive.go
@@ -1027,7 +1027,7 @@ func (o *Object) Update(in io.Reader, src fs.ObjectInfo, options ...fs.OpenOptio
 	o.id = closeResponse.FileID
 	o.size = closeResponse.Size
 
-	// Set the mod time now and read metadata
+	// Set the mod time now
 	err = o.SetModTime(modTime)
 	if err != nil {
 		return err
@@ -1049,7 +1049,7 @@ func (o *Object) Update(in io.Reader, src fs.ObjectInfo, options ...fs.OpenOptio
 		return err
 	}
 
-	return nil
+	return o.readMetaData()
 }
 
 func (o *Object) readMetaData() (err error) {

Original file line number	Diff line number	Diff line change
`@@ -1027,7 +1027,7 @@ func (o *Object) Update(in io.Reader, src fs.ObjectInfo, options ...fs.OpenOptio`
`1027`	`1027`	`o.id = closeResponse.FileID`
`1028`	`1028`	`o.size = closeResponse.Size`
`1029`	`1029`
`1030`		`- // Set the mod time now and read metadata`
	`1030`	`+ // Set the mod time now`
`1031`	`1031`	`err = o.SetModTime(modTime)`
`1032`	`1032`	`if err != nil {`
`1033`	`1033`	`return err`
`@@ -1049,7 +1049,7 @@ func (o *Object) Update(in io.Reader, src fs.ObjectInfo, options ...fs.OpenOptio`
`1049`	`1049`	`return err`
`1050`	`1050`	`}`
`1051`	`1051`
`1052`		`- return nil`
	`1052`	`+ return o.readMetaData()`
`1053`	`1053`	`}`
`1054`	`1054`
`1055`	`1055`	`func (o *Object) readMetaData() (err error) {`