fix: fixes for path mappings, tests, and coverage (angular#1359)

TheLarkInn · johannes.werner · commit f19461392265 · 2016-09-23T10:21:14.000+02:00
* fix(): Multiple fixes for path mappings:

* Removed invalid test case that was throwing path mappings  tests because of a typescript bug.
* Readded PathsPlugin for Path Mappings
* Removed coverage preprocessor which was throwing bad type errors against ts code when it shouldn't be.
* Added sourcemap support for istanbul instrumenter. Coverage files are still being generated.

* fix: fix the way the build command runs for mobile tests

* fix: fix the way the build command runs for mobile tests

* fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile

* fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile
diff --git a/addon/ng2/models/webpack-build-test.ts b/addon/ng2/models/webpack-build-test.ts
@@ -44,7 +44,6 @@ export const getWebpackTestConfig = function(projectRoot: string) {
               query: {
                 useWebpackText: true,
                 tsconfig: path.resolve(projectRoot, './src/tsconfig.json'),
-                // resolveGlobs: false,
                 module: "commonjs",
                 target: "es5",
                 useForkChecker: true,
@@ -67,7 +66,7 @@ export const getWebpackTestConfig = function(projectRoot: string) {
       ],
       postLoaders: [
         {
-          test: /\.(js|ts)$/, loader: 'istanbul-instrumenter-loader',
+          test: /\.(js|ts)$/, loader: 'sourcemap-istanbul-instrumenter-loader',
           exclude: [
             /\.(e2e|spec)\.ts$/,
             /node_modules/
diff --git a/addon/ng2/utilities/ts-path-mappings-webpack-plugin.ts b/addon/ng2/utilities/ts-path-mappings-webpack-plugin.ts
@@ -183,9 +183,6 @@ export class PathsPlugin implements ResolverPlugin {
             this.baseUrl
         );
 
-        console.log("CONFIG FILE AND BASE URL");
-        console.log(this.configFilePath, this.absoluteBaseUrl);
-
         this.mappings = [];
         let paths = this.options.paths || {};
         Object.keys(paths).forEach(alias => {
