designtestcode
diff --git a/‎__tests__/get.ts
Lines changed: 55 additions & 0 deletions b/‎__tests__/get.ts
Lines changed: 55 additions & 0 deletions
diff --git a/‎dist/Immutable.js
Lines changed: 13 additions & 11 deletions b/‎dist/Immutable.js
Lines changed: 13 additions & 11 deletions
@@ -0,0 +1,55 @@
+///<reference path='../resources/jest.d.ts'/>
+///<reference path='../dist/Immutable.d.ts'/>
+
+jest.autoMockOff();
+
+import I = require('immutable');
+
+describe('get', () => {
+
+  it('gets any index', () => {
+    var seq = I.Range(0, 100);
+    expect(seq.get(20)).toBe(20);
+  });
+
+  it('gets first', () => {
+    var seq = I.Range(0, 100);
+    expect(seq.first()).toBe(0);
+  });
+
+  it('gets last', () => {
+    var seq = I.Range(0, 100);
+    expect(seq.last()).toBe(99);
+  });
+
+  it('gets any index after reversing', () => {
+    var seq = I.Range(0, 100).reverse();
+    expect(seq.get(20)).toBe(79);
+  });
+
+  it('gets first after reversing', () => {
+    var seq = I.Range(0, 100).reverse();
+    expect(seq.first()).toBe(99);
+  });
+
+  it('gets last after reversing', () => {
+    var seq = I.Range(0, 100).reverse();
+    expect(seq.last()).toBe(0);
+  });
+
+  it('gets any index when length is unknown', () => {
+    var seq = I.Range(0, 100).filter(x => x % 2 === 1);
+    expect(seq.get(20)).toBe(41);
+  });
+
+  it('gets first when length is unknown', () => {
+    var seq = I.Range(0, 100).filter(x => x % 2 === 1);
+    expect(seq.first()).toBe(1);
+  });
+
+  it('gets last when length is unknown', () => {
+    var seq = I.Range(0, 100).filter(x => x % 2 === 1);
+    expect(seq.last()).toBe(99); // Note: this is O(N)
+  });
+
+});
@@ -519,7 +519,7 @@ var $Sequence = Sequence;
     return this.flip().valueSeq();
   },
   last: function() {
-    return this.findLast(returnTrue);
+    return this.reverse().first();
   },
   mapEntries: function(mapper, context) {
     var $__0 = this;
@@ -697,7 +697,7 @@ var $IndexedSequence = IndexedSequence;
     return interposeFactory(this, separator);
   },
   last: function() {
-    return this.get(this.length ? this.length - 1 : 0);
+    return this.get(-1);
   },
   skip: function(amount) {
     var seq = this;
@@ -1190,7 +1190,7 @@ function reverseFactory(sequence, useKeys) {
     return sequence.get(useKeys ? key : -1 - key, notSetValue);
   });
   reversedSequence.has = (function(key) {
-    return sequence.has(key);
+    return sequence.has(useKeys ? key : -1 - key);
   });
   reversedSequence.contains = (function(value) {
     return sequence.contains(value);
@@ -1213,14 +1213,16 @@ function reverseFactory(sequence, useKeys) {
 }
 function filterFactory(sequence, predicate, context, useKeys) {
   var filterSequence = sequence.__makeSequence();
-  filterSequence.has = (function(key) {
-    var v = sequence.get(key, NOT_SET);
-    return v !== NOT_SET && !!predicate.call(context, v, key, sequence);
-  });
-  filterSequence.get = (function(key, notSetValue) {
-    var v = sequence.get(key, NOT_SET);
-    return v !== NOT_SET && predicate.call(context, v, key, sequence) ? v : notSetValue;
-  });
+  if (useKeys) {
+    filterSequence.has = (function(key) {
+      var v = sequence.get(key, NOT_SET);
+      return v !== NOT_SET && !!predicate.call(context, v, key, sequence);
+    });
+    filterSequence.get = (function(key, notSetValue) {
+      var v = sequence.get(key, NOT_SET);
+      return v !== NOT_SET && predicate.call(context, v, key, sequence) ? v : notSetValue;
+    });
+  }
   filterSequence.__iterateUncached = function(fn, reverse) {
     var $__0 = this;
     var iterations = 0;