fix: nativeView accessor when $el is undefined. fixes nativescript-vue#595 (nativescript-vue#602)

msaelices · rigor789 · commit 6df135144a56 · 2020-01-13T19:04:32.000+01:00
* chore(samples): add sample app for reproducing nativescript-vue#595 * fix: fix "TypeError: Cannot read property 'nativeView' of undefined" accessing this.$options
diff --git a/platform/nativescript/runtime/index.js b/platform/nativescript/runtime/index.js
@@ -79,7 +79,7 @@ Vue.prototype.$start = function() {
 // Define a `nativeView` getter in every NS vue instance
 Object.defineProperty(Vue.prototype, 'nativeView', {
   get() {
-    return this.$el.nativeView
+    return this.$el ? this.$el.nativeView : undefined
   }
 })
 
diff --git a/samples/app/595.js b/samples/app/595.js
@@ -0,0 +1,36 @@
+const Vue = require('nativescript-vue')
+
+Vue.config.debug = true
+Vue.config.silent = false
+
+Plugin = {
+  install(Vue, name) {
+    Vue.prototype.$name = name
+
+    Vue.mixin({
+      beforeCreate: function() {
+        setTimeout(() => {
+          console.log('this.$options: ', this.$options)
+        }, 5000)
+      }
+    })
+  }
+}
+
+Vue.use(Plugin, 'pluginName')
+
+new Vue({
+  data: {},
+  template: `
+    <Frame>
+      <Page>
+        <ActionBar title="Issue #595" />
+
+        <StackLayout>
+          <Label text="This app should not crash in 5 seconds" />
+          <Label text="You will see a dump of this.$options in console" />
+        </StackLayout>
+      </Page>
+    </Frame>
+  `
+}).$start()

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ Vue.prototype.$start = function() {`
`79`	`79`	// Define a `nativeView` getter in every NS vue instance
`80`	`80`	`Object.defineProperty(Vue.prototype, 'nativeView', {`
`81`	`81`	`get() {`
`82`		`- return this.$el.nativeView`
	`82`	`+ return this.$el ? this.$el.nativeView : undefined`
`83`	`83`	`}`
`84`	`84`	`})`
`85`	`85`