8000 Samples refactoring to use a bundle app with webpack and support HMR … · designemail/nativescript-vue@3e8dd2f · GitHub
[go: up one dir, main page]

Skip to content

Commit 3e8dd2f

Browse files
authored
Samples refactoring to use a bundle app with webpack and support HMR and .vue files (nativescript-vue#476)
* feat (samples): Run the samples using a webpack bundle. Closer to real-world NS-vue apps. Allow any aditional parameters to the tns command like --hmr or whatever. * feat (samples): Add a sample with a Vue component to check the HMR feature. * Change NPM dev script to build to dist/index.js. Remove the dev:dist script as it is not useful now. Document new features * feat (samples): Fix live reload when changing the NS-vue code * feat (sample): Adapt all the import to nativescript-vue * feat (samples): Separate the details page into a new .vue component for better UX * fix (samples): Fix the 455.js sample which is now adapted to the new samples infrastructure * chore (v-slot): Add sample (currently failing) for testing v-slot in a .vue component
1 parent d240443 commit 3e8dd2f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+444
-50
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 2 deletions

build/sample-runner.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ const samplePackage = require('../samples/app/package.json')
66
const originalMain = samplePackage.main
77

88
let tns
9+
let args = process.argv.slice(2)
910

1011
const files = fs
1112
.readdirSync(path.resolve(__dirname, '../samples/app'))
@@ -40,11 +41,11 @@ inquirer
4041
})
4142

4243
function runPlatform(platform) {
43-
tns = spawn('tns', ['debug', platform], {
44+
tns = spawn('tns', ['debug', platform, '--syncAllFiles', '--bundle'].concat(args), {
4445
cwd: path.resolve(__dirname, '../samples')
4546
})
4647

47-
tns.on('error', err => console.log(err))
48+
tns.on('error', err => console.error(err))
4849
tns.stdout.on('data', data => process.stdout.write(platform + ': ' +data))
4950
}
5051

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@
1515
"test": "jest",
1616
"tdd": "jest --watch",
1717
"samples": "node build/sample-runner.js",
18-
"dev": "rollup -c build/config.js -w --o samples/app/nativescript-vue.js --environment TARGET:nativescript-vue",
19-
"dev:dist": "rollup -c build/config.js -w --o dist/index.js --environment TARGET:nativescript-vue",
18+
"dev": "rollup -c build/config.js -w --o dist/index.js --environment TARGET:nativescript-vue",
2019
"build": "node build/build.js",
2120
"build:docs": "cd docs && npm run build",
2221
"prettier": "prettier --no-semi --single-quote --write \"{{platform,__test__}/**/*.js,samples/app/*.js}\"",

samples/app/127.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const Vue = require('./nativescript-vue')
1+
const Vue = require('nativescript-vue')
22

33
Vue.config.debug = true
44
Vue.config.silent = false

samples/app/171.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const Vue = require('./nativescript-vue')
1+
const Vue = require('nativescript-vue')
22

33
Vue.config.silent = false
44

samples/app/217.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const Vue = require('./nativescript-vue')
1+
const Vue = require('nativescript-vue')
22

33
Vue.config.debug = true
44
Vue.config.silent = false

samples/app/220.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const Vue = require('./nativescript-vue')
1+
const Vue = require('nativescript-vue')
22

33
Vue.config.debug = true
44
Vue.config.silent = false

samples/app/229.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const Vue = require('./nativescript-vue')
1+
const Vue = require('nativescript-vue')
22

33
Vue.config.silent = false
44

samples/app/231.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const Vue = require('./nativescript-vue')
1+
const Vue = require('nativescript-vue')
22

33
Vue.config.silent = false
44

samples/app/240.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const Vue = require('./nativescript-vue')
1+
const Vue = require('nativescript-vue')
22

33
Vue.config.debug = true
44
Vue.config.silent = false

0 commit comments

Comments
 (0)
0