8000 Test improvement · dercoder/omnipay-paysafecard@b940fb1 · GitHub
[go: up one dir, main page]

Skip to content

Commit b940fb1

Browse files
committed
Test improvement
1 parent 7050fc4 commit b940fb1

File tree

2 files changed

+8
-25
lines changed

2 files changed

+8
-25
lines changed

src/Omnipay/Paysafecard/Message/CompletePurchaseRequest.php

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,6 @@ protected function getMethod()
2626
return 'executeDebit';
2727
}
2828

29-
public function setFetchTransactionRequest(FetchTransactionRequest $request)
30-
{
31-
$this->fetchTransaction = $request;
32-
33-
return $this;
34-
}
35-
3629
/**
3730
* Get the data for this request.
3831
*
@@ -119,11 +112,9 @@ public function getData()
119112
*/
120113
public function sendData($data)
121114
{
122-
if (!$this->fetchTransaction) {
123-
$this->fetchTransaction = new FetchTransactionRequest($this->httpClient, $this->httpRequest);
124-
}
115+
$fetchTransaction = new FetchTransactionRequest($this->httpClient, $this->httpRequest);
125116

126-
$response = $this->fetchTransaction->initialize(array(
117+
$response = $fetchTransaction->initialize(array(
127118
'testMode' => $this->getTestMode(),
128119
'username' => $this->getUsername(),
129120
'password' => $this->getPassword(),

tests/Omnipay/Paysafecard/Message/CompletePurchaseRequestTest.php

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,12 @@ public function setUp()
1616
$httpCompletePurchaseResponse = $this->getMockHttpResponse('CompletePurchaseSuccess.txt');
1717
$httpFetchTransactionResponse = $this->getMockHttpResponse('FetchTransactionPending.txt');
1818

19-
$mockCompletePurchasePlugin = new \Guzzle\Plugin\Mock\MockPlugin();
20-
$mockCompletePurchasePlugin->addResponse($httpCompletePurchaseResponse);
21-
22-
$mockFetchTransactionPlugin = new \Guzzle\Plugin\Mock\MockPlugin();
23-
$mockFetchTransactionPlugin->addResponse($httpFetchTransactionResponse);
24-
25-
$httpCompletePurchaseClient = new HttpClient();
26-
$httpCompletePurchaseClient->addSubscriber($mockCompletePurchasePlugin);
19+
$mockPlugin = new \Guzzle\Plugin\Mock\MockPlugin();
20+
$mockPlugin->addResponse($httpFetchTransactionResponse);
21+
$mockPlugin->addResponse($httpCompletePurchaseResponse);
2722

28-
$httpFetchTransactionClient = new HttpClient();
29-
$httpFetchTransactionClient->addSubscriber($mockFetchTransactionPlugin);
23+
$httpClient = new HttpClient();
24+
$httpClient->addSubscriber($mockPlugin);
3025

3126
$httpRequest = new HttpRequest(array(
3227
'mtid' => 'TX9997888',
@@ -35,14 +30,11 @@ public function setUp()
3530
'currency' => 'EUR'
3631
));
3732

38-
$this->request = new CompletePurchaseRequest($httpCompletePurchaseClient, $httpRequest);
33+
$this->request = new CompletePurchaseRequest($httpClient, $httpRequest);
3934
$this->request->initialize(array(
4035
'username' => 'SOAP_USERNAME',
4136
'password' => 'oJ2rHLBVSbD5iGfT'
4237
));
43-
44-
$fetchTransaction = new FetchTransactionRequest($httpFetchTransactionClient, new HttpRequest());
45-
$this->request->setFetchTransactionRequest($fetchTransaction);
4638
}
4739

4840
public function testExceptions()

0 commit comments

Comments
 (0)
0