fix: NULL pointer not being recognized (#26)

tjosepo · web-flow · commit 54c02b45917b · 2022-08-30T15:23:15.000+05:30
diff --git a/src/python.ts b/src/python.ts
@@ -194,6 +194,7 @@ export class PyObject {
    */
   get isNone() {
     return this.handle === 0 ||
+      this.handle === 0n ||
       this.handle === python.None[ProxiedPyObject].handle;
   }
 
diff --git a/test/test.ts b/test/test.ts
@@ -1,4 +1,4 @@
-import { assert, assertEquals } from "./deps.ts";
+import { assert, assertEquals, assertThrows } from "./deps.ts";
 import {
   kw,
   NamedArgument,
@@ -294,3 +294,15 @@ def call(cb):
   );
   cb.destroy();
 });
+
+Deno.test("exceptions", async (t) => {
+  await t.step("simple exception", () => {
+    assertThrows(() => python.runModule("1 / 0"));
+  });
+
+  await t.step("exception with traceback", () => {
+    const np = python.import("numpy");
+    const array = np.zeros([2, 3, 4]);
+    assertThrows(() => array.shape = [3, 6]);
+  });
+});

Original file line number	Diff line number	Diff line change
`@@ -194,6 +194,7 @@ export class PyObject {`
`194`	`194`	`*/`
`195`	`195`	`get isNone() {`
`196`	`196`	`return this.handle === 0 \|\|`
	`197`	`+ this.handle === 0n \|\|`
`197`	`198`	`this.handle === python.None[ProxiedPyObject].handle;`
`198`	`199`	`}`
`199`	`200`