10000 fix: ci (#69) · denosaurs/deno_python@1e2e1ad · GitHub
[go: up one dir, main page]

Skip to content

Commit 1e2e1ad

Browse files
authored
fix: ci (#69)
1 parent 43e4957 commit 1e2e1ad

File tree

4 files changed

+20
-14
lines changed

4 files changed

+20
-14
lines changed

.github/workflows/checks.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,13 @@ jobs:
6565
python-version: '3.12'
6666

6767
- name: Install NumPy
68+
if: ${{ matrix.os != 'macos-latest' }}
6869
run: python3 -m pip install numpy
6970

71+
- name: Install NumPy on MacOs
72+
if: ${{ matrix.os == 'macos-latest' }}
73+
run: python3 -m pip install --user --break-system-packages numpy
74+
7075
- name: Run deno test
7176
run: deno task test
7277

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,13 @@ plt.plot(xpoints, ypoints);
3232
plt.show();
3333
```
3434

35-
When running, you **must** specify `--allow-ffi`, `--allow-env` and `--unstable`
36-
flags. Alternatively, you may also just specify `-A` instead of specific
37-
permissions since enabling FFI effectively escapes the permissions sandbox.
35+
When running, you **must** specify `--allow-ffi`, `--allow-env` and
36+
`--unstable-ffi` flags. Alternatively, you may also just specify `-A` instead of
37+
specific permissions since enabling FFI effectively escapes the permissions
38+
sandbox.
3839

3940
```shell
40-
deno run -A --unstable <file>
41+
deno run -A --unstable-ffi <file>
4142
```
4243

4344
### Usage in Bun

deno.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
{
22
"tasks": {
33
"check": "deno task check:mod && deno task check:ext && deno task check:examples",
4-
"check:mod": "deno check --unstable mod.ts",
5-
"check:ext": "deno check --unstable ext/*.ts",
6-
"check:examples": "deno check --unstable examples/*.ts",
7-
"test": "deno test --unstable -A test/test.ts",
8-
"example:hello_python": "deno run -A --unstable examples/hello_python.ts",
9-
"example:matplotlib": "deno run -A --unstable examples/matplotlib.ts",
10-
"example:pip_import": "deno run -A --unstable examples/pip_import.ts",
11-
"example:run_code": "deno run -A --unstable examples/run_code.ts",
12-
"example:tensorflow": "deno run -A --unstable examples/tensorflow.ts"
4+
"check:mod": "deno check --unstable-ffi mod.ts",
5+
"check:ext": "deno check --unstable-ffi ext/*.ts",
6+
"check:examples": "deno check --unstable-ffi examples/*.ts",
7+
"test": "deno test --unstable-ffi -A test/test.ts",
8+
"example:hello_python": "deno run -A --unstable-ffi examples/hello_python.ts",
9+
"example:matplotlib": "deno run -A --unstable-ffi examples/matplotlib.ts",
10+
"example:pip_import": "deno run -A --unstable-ffi examples/pip_import.ts",
11+
"example:run_code": "deno run -A --unstable-ffi examples/run_code.ts",
12+
"example:tensorflow": "deno run -A --unstable-ffi examples/tensorflow.ts"
1313
}
1414
}

src/ffi.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ for (const path of searchPath) {
4444
} catch (err) {
4545
if (err instanceof TypeError && !("Bun" in globalThis)) {
4646
throw new Error(
47-
"Cannot load dynamic library because --unstable flag was not set",
47+
"Cannot load dynamic library because --unstable-ffi flag was not set",
4848
{ cause: err },
4949
);
5050
}

0 commit comments

Comments
 (0)
0