8000 Incorrectly identifying UNLICENSED as public domain · Issue #18 · delfrrr/npm-consider · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly identifying UNLICENSED as public domain #18

Open
Rycochet opened this issue Sep 2, 2019 · 1 comment · May be fixed by #27
Open

Incorrectly identifying UNLICENSED as public domain #18

Rycochet opened this issue Sep 2, 2019 · 1 comment · May be fixed by #27

Comments

@Rycochet
Copy link
Rycochet commented Sep 2, 2019

Looks like it may be checking things in a specific order, so it's identifying it as "Unlicense" (which is a correct license).

https://docs.npmjs.com/files/package.json

Finally, if you do not wish to grant others the right to use a private or unpublished package under any terms:
{ "license": "UNLICENSED" }

I'd suggest doing a longest-fit search for the license, so it can get the correct category.

If someone puts the wrong license in their package.json then that is an issue for them to fix ;-)
@brettz9
Copy link
brettz9 commented Dec 25, 2019

This is pretty significant as it is completely the opposite. As with #24 , I think this could merit a whole new category since "Unlicensed" is not really "uncategorized" (though that would currently be the best fit); it is at least known to be forbidden for reuse. With "uncategorized", you know that there is a greater chance that you can contact the project owners to see whether they intended an open license.

@brettz9 brettz9 linked a pull request Jan 9, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat UNLICENSED as special case for comparisons
2 participants
@brettz9 @Rycochet
0