8000 npm-consider fails on "Impact" · Issue #11 · delfrrr/npm-consider · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm-consider fails on "Impact" #11

Open
Themayu opened this issue Sep 16, 2018 · 2 comments
Open

npm-consider fails on "Impact" #11

Themayu opened this issue Sep 16, 2018 · 2 comments
Assignees
@delfrrr

Comments

@Themayu
Copy link
Themayu commented Sep 16, 2018 •
edited
Loading

The issue is exactly as the title says: npm-consider 8000 seems to fail when selecting Impact. Associated command output with stack trace is below (tested using express with command npm-consider install --save express):

***@***:~/proj/zifar$ npm-consider install --save express
express@4.16.3 (updated 6 months ago)
Packages  51
Size      535.18 KB
Licenses  Permissive  51
? What is next? Impact
TypeError: Cannot read property 'saveDev' of undefined
    at getLocalPackage.then (/mnt/c/Users/***/AppData/Roaming/npm/node_modules/npm-consider/lib/showImpact.js:69:25)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

Note that this error also occurs if I attempt to use the module directly in the Windows command prompt.
@Themayu
Copy link
Author
Themayu commented Sep 16, 2018 •
edited
Loading

Edit: accidentally hit CTRL+ENTER while writing, then realised what I was typing didn't even matter anyway so I removed it.

@delfrrr delfrrr self-assigned this Sep 18, 2018
@fgeorges
Copy link
fgeorges commented Nov 17, 2019 •
edited
Loading

Just got the same error, it seems, on macOS. The following is what I tried exactly:

$ npm install -g npm-consider
/Users/xxx/.nvm/versions/node/v13.1.0/bin/npm-consider -> /Users/xxx/.nvm/versions/node/v13.1.0/lib/node_modules/npm-consider/bin/npm-consider.js
+ npm-consider@1.7.0
added 59 packages from 45 contributors in 4.783s

$ npm-consider install --save handlebars
handlebars@4.5.2 (updated 4 days ago)
Packages  8             
Size      1.01 MB       
Licenses  Permissive  8 
? What is next? Impact
TypeError: Cannot read property 'saveDev' of undefined
    at /Users/xxx/.nvm/versions/node/v13.1.0/lib/node_modules/npm-consider/lib/showImpact.js:69:25
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

As this been fixed somehow?

Or maybe someone has any clue on the problem, so I could try and help myself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delfrrr delfrrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@delfrrr @fgeorges @Themayu
0