chore: add basic type checks to meta tests

nejch · JohnVillalovos · commit 545d6d60673c · 2022-10-27T08:06:52.000-07:00
diff --git a/pyproject.toml b/pyproject.toml
@@ -14,13 +14,15 @@ module = [
     "docs.ext.*",
     "tests.functional.*",
     "tests.functional.api.*",
-    "tests.meta.*",
     "tests.unit.*",
 ]
 ignore_errors = true
 
 [[tool.mypy.overrides]]
-module = "tests.smoke.*"
+module = [
+    "tests.meta.*",
+    "tests.smoke.*",
+]
 disable_error_code = ["no-untyped-def"]
 
 [tool.semantic_release]
diff --git a/tests/meta/test_ensure_type_hints.py b/tests/meta/test_ensure_type_hints.py
@@ -9,7 +9,7 @@
 import inspect
 from typing import Optional, Type
 
-import _pytest
+import pytest
 
 import gitlab.mixins
 import gitlab.v4.objects
@@ -19,7 +19,7 @@
 @dataclasses.dataclass(frozen=True)
 class ClassInfo:
     name: str
-    type: Type
+    type: Type  # type: ignore[type-arg]
 
     def __lt__(self, other: object) -> bool:
         if not isinstance(other, ClassInfo):
@@ -32,7 +32,7 @@ def __eq__(self, other: object) -> bool:
         return (self.type.__module__, self.name) == (other.type.__module__, other.name)
 
 
-def pytest_generate_tests(metafunc: _pytest.python.Metafunc) -> None:
+def pytest_generate_tests(metafunc: pytest.Metafunc) -> None:
     """Find all of the classes in gitlab.v4.objects and pass them to our test
     function"""
 
@@ -106,7 +106,7 @@ def test_check_get_without_id_function_type_hints(
     def get_check_helper(
         self,
         *,
-        base_type: Type,
+        base_type: Type,  # type: ignore[type-arg]
         class_info: ClassInfo,
         method_template: str,
         optional_return: bool,
