Check for None & len() of ET.Element instead of bool()

dcermak · dcermak · commit 0bb2f49c342e · 2024-08-16T11:51:39.000+02:00
The bool() of ET.Element is discouraged from being used, see: python/cpython#83122
diff --git a/osc/_private/package.py b/osc/_private/package.py
@@ -66,9 +66,9 @@ def _get_meta_node(self):
         raise NotImplementedError()
 
     def get_meta_value(self, option):
-        if not self._meta_node:
+        if self._meta_node is None or len(self._meta_node) == 0:
             self._meta_node = self._get_meta_node()
-        if not self._meta_node:
+        if self._meta_node is None or len(self._meta_node) == 0:
             return None
         node = api.find_node(self._meta_node, "package", option)
         if node is None or not node.text:
