Ref symfony#15: Added small comment + get context outside of foreach loop

lolautruche · lolautruche · commit 473c6059c8b7 · 2012-09-21T17:39:05.000+02:00
diff --git a/ChainRouter.php b/ChainRouter.php
@@ -91,10 +91,12 @@ public function all()
         if (empty($this->sortedRouters)) {
             $this->sortedRouters = $this->sortRouters();
 
+            // setContext() is done here instead of in add() to avoid fatal errors when clearing and warming up caches
+            // See https://github.com/symfony-cmf/Routing/pull/18
             $context = $this->getContext();
-            foreach ($this->sortedRouters as $router) {
-                if ($router instanceof RequestContextAwareInterface) {
-                    if (null !== $context) {
+            if (null !== $context) {
+                foreach ($this->sortedRouters as $router) {
+                    if ($router instanceof RequestContextAwareInterface) {
                         $router->setContext($context);
                     }
                 }
