Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 15 commits
- 4 files changed
- 1 contributor
Commits on Mar 22, 2022
-
There should be no need to install the signal handlers to close the connection if the application terminates. If it does, the OS will close all the file handles owned by the terminating process, among which the sockets used by the connection. And upon closure, the TCP stack will properly issue a reset which will be noticed by the remote server. The issue is that, on top of what already underlined in the existing comments (override of user specified signals), setting a signal handler from outside the main thread will result with an error: ``` ER20220322 17:42:45.726997;root;utils: File "/usr/local/lib/python3.8/dist-packages/polygon/websocket/websocket_client.py", line 42, in __init__ ER20220322 17:42:45.726997;root;utils: signal.signal(signal.SIGINT, self._cleanup_signal_handler()) ER20220322 17:42:45.726997;root;utils: File "/usr/lib/python3.8/signal.py", line 47, in signal ER20220322 17:42:45.726997;root;utils: handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler)) ER20220322 17:42:45.726997;root;utils: ValueError: signal only works in main thread ``` This in turn leads to the inability to create a websocket connection from outside the main thread.
Commits on Mar 25, 2022
Commits on May 1, 2025
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master