GHA: Try strict unhandle promise handling

davedoesdev · davedoesdev · commit 766910c206cc · 2021-10-27T23:26:50.000+01:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,9 +23,6 @@ jobs:
       - name: Use Node ${{ matrix.node-version }}
         uses: actions/setup-node@v2
 
-      - name: Test Node exit status
-        run: node -e 'throw new Error("foo")' || echo $?
-
       - name: Install requirements
         run: |
           pip install -r requirements.txt
diff --git a/test/jose_interop_vows.py b/test/jose_interop_vows.py
@@ -15,14 +15,11 @@ def spawn(cmd, parse_json):
     """ run node command """
     #pylint: disable=E1101
     with lock:
-        p = Popen(["node", "-e", "fixtures=require('./test/fixtures');" + cmd], #pylint: disable=consider-using-with
+        p = Popen(["node", "--unhandled-rejections=strict", "-e", "fixtures=require('./test/fixtures');" + cmd], #pylint: disable=consider-using-with
                   stdout=PIPE, stderr=PIPE)
         (stdout, stderr) = p.communicate()
     stdout = stdout.decode('utf-8')
     stderr = stderr.decode('utf-8')
-    print("stdout: %s" % stdout)
-    print("stderr: %s" % stderr)
-    print("returncode: %d" % p.returncode)
     if p.returncode == 0:
         return json_decode(stdout) if parse_json else stdout
     raise Exception(stderr if stderr else ('exited with {}'.format(p.returncode)))
