8000 feat: add support for specifying a data type "kind" in `astype` by lucascolley · Pull Request #848 · data-apis/array-api · GitHub
[go: up one dir, main page]
Skip to content

feat: add support for specifying a data type "kind" in astype #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: add support for specifying a data type "kind" in astype #848

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2a82758
feat: `astype`: accept a kind of data type
lucascolley Oct 24, 2024
419041b
try to fix docs build
lucascolley Oct 24, 2024
302cf1a 8000
change signature
lucascolley Oct 24, 2024
3186995
run pre-commit
lucascolley Oct 24, 2024
90aa750
address review comments
lucascolley Oct 27, 2024
41880c0
adjust wording
lucascolley Oct 28, 2024
d4450b3
add note on unspecified promotion
lucascolley Oct 28, 2024
1b056ad
improve formatting
lucascolley Oct 28, 2024
169ea5e
refactor: update guidance to generalize across data type kinds
kgryte Jan 23, 2025
ecd0f59
fix: update copy
kgryte Jan 23, 2025
b61122a
docs: update copy
kgryte Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adjust wording
  • Loading branch information
@lucascolley
lucascolley committed Oct 28, 2024
commit 41880c096c1aaedff9f47a207cd6b67501ee1f9e
10 changes: 5 additions & 5 deletions src/array_api_stubs/_draft/data_type_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ def astype(
Returns
-------
out: array
For ``dtype_or_kind`` a data type, an array having the specified data type.
For ``dtype_or_kind`` a kind of data type:
- If ``x.dtype`` is already of that kind, the data type is maintained.
- Otherwise, an attempt is made to convert to the specified kind, according to the type promotion rules (see :ref:`type-promotion`).
For ``dtype`` a data type, an array having the specified data type.
For ``dtype`` a kind of data type:
- If ``x.dtype`` is already of that kind, the data type must be maintained.
- Otherwise, ``x`` should be cast to a data type of that kind, according to the type promotion rules (see :ref:`type-promotion`) and the above notes.

- Numeric kinds are interpreted as the lowest-precision standard data type of that kind for the purposes of type promotion. For example, ``astype(x, 'complex floating')`` will return an array with the data type ``complex64`` when ``x.dtype`` is ``float32``, since ``complex64`` is the result of promoting ``float32`` with the lowest-precision standard complex data type, ``complex64``.
- Kinds must be interpreted as the lowest-precision standard data type of that kind for the purposes of type promotion. For example, ``astype(x, 'complex floating')`` will return an array with the data type ``complex64`` when ``x.dtype`` is ``float32``, since ``complex64`` is the result of promoting ``float32`` with the lowest-precision standard complex data type, ``complex64``.

The returned array must have the same shape as ``x``.

Expand Down
Loading
0