8000 Clean up duplicate blurbs on function conventions; improve `fft` description by rgommers · Pull Request #576 · data-apis/array-api · GitHub
[go: up one dir, main page]
Skip to content

Clean up duplicate blurbs on function conventions; improve fft description #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2022
Merged

Clean up duplicate blurbs on function conventions; improve fft description #576

merged 3 commits into from
Dec 19, 2022

Conversation

rgommers
Copy link
Member
@rgommers rgommers commented Dec 15, 2022 •
edited by kgryte
Loading

This also fixes some inconsistencies and clarifies that not all positional/keyword arguments are positional-only or keyword-only (the signature of each function defines this precisely).

Resolves #223.

@rgommers rgommers added Maintenance Bug fix, typo fix, or general maintenance. Narrative Content Narrative documentation content. labels Dec 15, 2022
@rgommers rgommers added this to the v2022 milestone Dec 15, 2022
@rgommers rgommers requested a review from kgryte December 15, 2022 21:16
@rgommers rgommers mentioned this pull request Dec 16, 2022
Open
13 tasks
kgryte
kgryte reviewed Dec 19, 2022
View reviewed changes
kgryte
kgryte reviewed Dec 19, 2022
View reviewed changes
kgryte
kgryte reviewed Dec 19, 2022
View reviewed changes
kgryte
kgryte reviewed Dec 19, 2022
View reviewed changes
Copy link
Contributor
@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo a couple of rephrasing suggestions.

rgommers and others added 2 commits December 19, 2022 22:11
@rgommers @kgryte
Update spec/API_specification/index.rst
3e0efdf 
Co-authored-by: Athan <kgryte@gmail.com>
@rgommers @kgryte
Apply suggestions from code review
00a9793 
Co-authored-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor
@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rgommers! In it goes!

@kgryte kgryte merged commit bbd66fb into data-apis:main Dec 19, 2022
@rgommers rgommers deleted the cleanup-convention-blurbs branch December 20, 2022 12:18
@rgommers rgommers added the topic: FFT Fast Fourier transforms. label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance. Narrative Content Narrative documentation content. topic: FFT Fast Fourier transforms.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.

Refactor the boilerplate text at the top of each API spec section
2 participants
@rgommers @kgryte
0