10000 Add a description of how to adopt the API by rgommers · Pull Request #33 · data-apis/array-api · GitHub
[go: up one dir, main page]
Skip to content

Add a description of how to adopt the API #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 22, 2020
+56 −0
Merged

Add a description of how to adopt the API #33

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e90359
Add a description of how to adopt the API
rgommers Sep 8, 2020
fd63c5d
Change the namespace convention to `xp` (borrowed from CuPy)
rgommers Sep 13, 2020
3a36812
Clarify that using an API version to retrieve the namespace is optional
rgommers Sep 13, 2020
8ecf1e9
Minor textual clarification to address review comment.
rgommers Oct 22, 2020
66ade24
Merge branch 'master' into how-to-adopt
rgommers Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor textual clarification to address review comment.
  • Loading branch information
@rgommers
rgommers committed Oct 22, 2020
commit 8ecf1e9c960abb5667f9c515409bf27ffab894bd
6 changes: 3 additions & 3 deletions spec/purpose_and_scope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@ namespace (e.g. `import package_name.array_api`). This has two issues though:
2. It is difficult to _version_ the array API standard implementation (see
:ref:`api-versioning`).

To address both issues, a uniform method must be provided by a conforming
implementation to access the API namespace, namely a function:
To address both issues, a uniform way must be provided by a conforming
implementation to access the API namespace, namely a method on the array object:

```
xp = x.__array_namespace__()
```

The function must take one keyword, `api_version=None`, to make it possible to
The method must take one keyword, `api_version=None`, to make it possible to
request a specific API version:

```
Expand Down
0