Improve timeout error when timeout is browser default (axios#3209)

dobesv · jasonsaayman · web-flow · commit 96956e30ba27 · 2021-09-16T21:16:43.000+02:00
I seems like the browser imposes a default timeout despite the documented default timeout being "never".  When this timeout occurs, axios confusingly reports an error "timeout of 0ms exceeded".  This change the message to avoid the confusing "0ms" part.

Co-authored-by: Jay &lt;jasonsaayman@gmail.com&gt;
diff --git a/lib/adapters/xhr.js b/lib/adapters/xhr.js
@@ -104,7 +104,7 @@ module.exports = function xhrAdapter(config) {
 
     // Handle timeout
     request.ontimeout = function handleTimeout() {
-      var timeoutErrorMessage = 'timeout of ' + config.timeout + 'ms exceeded';
+      var timeoutErrorMessage = config.timeout ? 'timeout of ' + config.timeout + 'ms exceeded' : 'timeout exceeded';
       if (config.timeoutErrorMessage) {
         timeoutErrorMessage = config.timeoutErrorMessage;
       }

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ module.exports = function xhrAdapter(config) {`
`104`	`104`
`105`	`105`	`// Handle timeout`
`106`	`106`	`request.ontimeout = function handleTimeout() {`
`107`		`- var timeoutErrorMessage = 'timeout of ' + config.timeout + 'ms exceeded';`
	`107`	`+ var timeoutErrorMessage = config.timeout ? 'timeout of ' + config.timeout + 'ms exceeded' : 'timeout exceeded';`
`108`	`108`	`if (config.timeoutErrorMessage) {`
`109`	`109`	`timeoutErrorMessage = config.timeoutErrorMessage;`
`110`	`110`	`}`