8000 [CP] Issue 49097. Resolve constants in enhanced enum constructors/methods. · Issue #49117 · dart-lang/sdk · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Issue 49097. Resolve constants in enhanced enum constructors/methods. #49117

Closed
scheglov opened this issue May 26, 2022 · 2 comments
Closed

[CP] Issue 49097. Resolve constants in enhanced enum constructors/methods. #49117

scheglov opened this issue May 26, 2022 · 2 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@scheglov
Copy link
Contributor

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/246041

Target

stable

Issue Description

#49097

There was a bug in enhanced enums implementation in the analyzer - we failed to resolve default values for constructors and methods.

What is the fix

With the referenced CL we will resolve these constant expressions.

Why cherry-pick

This bug causes false positive diagnostics reported.

Risk

low

Issue link(s)

#49097

Extra Info

No response
@scheglov scheglov added the cherry-pick-review Issue that need cherry pick triage to approve label May 26, 2022
@scheglov scheglov changed the title [CP] <title> [CP] Issue 49097. Resolve constants in enhanced enum constructors/methods. May 26, 2022
@mit-mit
Copy link
Member
mit-mit commented May 30, 2022

Including this with the next batch of picks SGTM

@vsmenon
Copy link
Member
vsmenon commented May 31, 2022

lgtm

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label May 31, 2022
7712
@a-siva a-siva added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jun 1, 2022
@athomas athomas closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@scheglov @vsmenon @whesse @a-siva @itsjustkevin @mit-mit @athomas
0