8000 fixed #13788 - CI-unixish-docker.yml: replaced `ubuntu:24.10` with `ubuntu:25.04` / cleanups by firewave · Pull Request #7472 · danmar/cppcheck · GitHub
[go: up one dir, main page]

Skip to content

fixed #13788 - CI-unixish-docker.yml: replaced ubuntu:24.10 with ubuntu:25.04 / cleanups #7472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

firewave
Copy link
Collaborator

No description provided.

env:
# TODO: figure out why there are cache misses with PCH enabled
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out this was working just fine in this workflow although we forgot to disable the precompiled headers. So we should be able to enable them in the other jobs as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first run also got cache hits which was unexpected. Turns out we are lacking the branch name in the cache key which causes it to be used across all builds (IIRC I assumed the cache is limited to the branch). So any PR will affect the cache of main builds.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also create a new cache with each build because it automatically appends a timestamp. That is done to prevent issues with concurrent access (see hendrikmuhs/ccache-action#117). It seems that might not be necessary for branches but since multiple pushes trigger multiple builds we cannot disable this. That would require us to cancel the already running builds (see https://trac.cppcheck.net/ticket/12325).

@firewave firewave changed the title fixed #13788 - CI-unixish-docker.yml: replaced ubuntu:24.10 with ùbuntu:25.04 / cleanups fixed #13788 - CI-unixish-docker.yml: replaced ubuntu:24.10 with ubuntu:25.04 / cleanups Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0