8000 Widening types for Message.from_dict · Issue #432 · danielgtaylor/python-betterproto · GitHub
[go: up one dir, main page]
Skip to content
< 10000 header class="HeaderMktg header-logged-out js-details-container js-header Details f4 py-3" role="banner" data-is-top="true" data-color-mode=light data-light-theme=light data-dark-theme=dark>

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
Widening types for Message.from_dict #432
New issue
New issue
Closed
#451
Closed
Widening types for Message.from_dict#432
#451
Labels
enhancementNew feature or requestgood first issueGood for newcomerssmallLow effort issue that can easily be picked up
@Gobot1234

Description

@Gobot1234
Gobot1234
opened on Oct 6, 2022

Considering Message.from_dict doesn't actually need to mutate or really even need the value parameter to be a dict would it be possible to widen the type to Mapping[str, Any]?

This would allow me to parse from TypedDicts which I think would be a useful for others to use.

Anyone have any objections to this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgood first issueGood for newcomerssmallLow effort issue that can easily be picked up

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0