Apply the heap vs. stack fix for PG::Result#fields too.

ged · ged · commit 07d33ca8ec82 · 2012-08-10T14:34:45.000-07:00
diff --git a/ext/pg_result.c b/ext/pg_result.c
@@ -861,16 +861,16 @@ pgresult_fields(VALUE self)
 {
 	PGresult *result = pgresult_get( self );
 	int n = PQnfields( result );
-	VALUE fields[ n ];
+	VALUE fields = rb_ary_new2( n );
 	int i;
 
 	for ( i = 0; i < n; i++ ) {
 		VALUE val = rb_tainted_str_new2(PQfname(result, i));
 		ASSOCIATE_INDEX(val, self);
-		fields[ i ] = val;
+		rb_ary_store( fields, i, val );
 	}
 
-	return rb_ary_new4( n, fields );
+	return fields;
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -861,16 +861,16 @@ pgresult_fields(VALUE self)`
`861`	`861`	`{`
`862`	`862`	`PGresult *result = pgresult_get( self );`
`863`	`863`	`int n = PQnfields( result );`
`864`		`- VALUE fields[ n ];`
	`864`	`+ VALUE fields = rb_ary_new2( n );`
`865`	`865`	`int i;`
`866`	`866`
`867`	`867`	`for ( i = 0; i < n; i++ ) {`
`868`	`868`	`VALUE val = rb_tainted_str_new2(PQfname(result, i));`
`869`	`869`	`ASSOCIATE_INDEX(val, self);`
`870`		`- fields[ i ] = val;`
	`870`	`+ rb_ary_store( fields, i, val );`
`871`	`871`	`}`
`872`	`872`
`873`		`- return rb_ary_new4( n, fields );`
	`873`	`+ return fields;`
`874`	`874`	`}`
`875`	`875`
`876`	`876`