Check for non-real timestamps

brian-brazil · brian-brazil · commit afe09a356fa8 · 2018-10-03T14:14:13.000+01:00
Signed-off-by: Brian Brazil &lt;brian.brazil@robustperception.io&gt;
diff --git a/prometheus_client/openmetrics/parser.py b/prometheus_client/openmetrics/parser.py
@@ -75,7 +75,10 @@ def _parse_timestamp(timestamp):
             return core.Timestamp(int(parts[0]), int(parts[1][:9].ljust(9, "0")))
         except ValueError:
             # Float.
-            return float(timestamp)
+            ts = float(timestamp)
+            if math.isnan(ts) or math.isinf(ts):
+                raise ValueError("Invalid timestamp: {0!r}".format(timestamp))
+            return ts
 
 
 def _parse_labels(it, text):
diff --git a/tests/openmetrics/test_parser.py b/tests/openmetrics/test_parser.py
@@ -477,6 +477,10 @@ def test_invalid_input(self):
                 ('a 1 z\n# EOF\n'),
                 ('a 1 1z\n# EOF\n'),
                 ('a 1 1.1.1\n# EOF\n'),
+                ('a 1 NaN\n# EOF\n'),
+                ('a 1 Inf\n# EOF\n'),
+                ('a 1 +Inf\n# EOF\n'),
+                ('a 1 -Inf\n# EOF\n'),
                 # Bad exemplars.
                 ('# TYPE a histogram\na_bucket{le="+Inf"} 1 #\n# EOF\n'),
                 ('# TYPE a histogram\na_bucket{le="+Inf"} 1# {} 1\n# EOF\n'),
