Remove 6 list_* functions that I missed

sigmavirus24 · sigmavirus24 · commit 6393b761f75b · 2013-02-12T09:49:06.000-05:00
diff --git a/.pep8 b/.pep8
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -30,6 +30,11 @@ History/Changelog
 
 - In github3.api, ``iter_repo_issues``'s signature has been corrected.
 
+- Remove ``list_{labels, comments, events}`` methods from github3.issues.Issue
+
+- Remove ``list_{comments, commits, files}`` methods from 
+  github3.pulls.PullRequest
+
 - In github3.gists.Gist:
 
   - the ``user`` attribute was changed by GitHub and is now the ``owner`` 
diff --git a/github3/issues.py b/github3/issues.py
@@ -122,16 +122,6 @@ def iter_labels(self, number=-1):
         url = self._build_url('labels', base_url=self._api)
         return self._iter(int(number), url, Label)
 
-    def list_labels(self):
-        """List the labels for every issue associated with this
-        milestone.
-
-        :returns: list of :class:`Label <Label>`\ s
-        """
-        url = self._build_url('labels', base_url=self._api)
-        json = self._json(self._get(url), 200)
-        return [Label(label, self) for label in json]
-
     @requires_auth
     def update(self, title, state='', description='', due_on=''):
         """Update this milestone.
@@ -339,15 +329,6 @@ def iter_comments(self, number=-1):
         url = self._build_url('comments', base_url=self._api)
         return self._iter(int(number), url, IssueComment)
 
-    def list_comments(self):
-        """List comments on this issue.
-
-        :returns: list of :class:`IssueComment <IssueComment>`
-        """
-        url = self._build_url('comments', base_url=self._api)
-        json = self._json(self._get(url), 200)
-        return [IssueComment(comment, self) for comment in json]
-
     def iter_events(self, number=-1):
         """Iterate over events associated with this issue only.
 
@@ -358,15 +339,6 @@ def iter_events(self, number=-1):
         url = self._build_url('events', base_url=self._api)
         return self._iter(int(number), url, IssueEvent)
 
-    def list_events(self):
-        """List events associated with this issue only.
-
-        :returns: list of :class:`IssueEvent <IssueEvent>`\ s
-        """
-        url = self._build_url('events', base_url=self._api)
-        json = self._json(self._get(url), 200)
-        return [IssueEvent(event, self) for event in json]
-
     @requires_auth
     def remove_label(self, name):
         """Removes label ``name`` from this issue.
diff --git a/github3/pulls.py b/github3/pulls.py
@@ -201,15 +201,6 @@ def iter_comments(self, number=-1):
         url = self._build_url('comments', base_url=self._api)
         return self._iter(int(number), url, ReviewComment)
 
-    def list_comments(self):
-        """List the comments on this pull request.
-
-        :returns: list of :class:`ReviewComment <ReviewComment>`\ s
-        """
-        url = self._build_url('comments', base_url=self._api)
-        json = self._json(self._get(url), 200)
-        return [ReviewComment(comment, self) for comment in json]
-
     def iter_commits(self, number=-1):
         """Iterates over the commits on this pull request.
 
@@ -220,15 +211,6 @@ def iter_commits(self, number=-1):
         url = self._build_url('commits', base_url=self._api)
         return self._iter(int(number), url, Commit)
 
-    def list_commits(self):
-        """List the commits on this pull request.
-
-        :returns: list of :class:`Commit <github3.git.Commit>`\ s
-        """
-        url = self._build_url('commits', base_url=self._api)
-        json = self._json(self._get(url), 200)
-        return [Commit(commit, self) for commit in json]
-
     def iter_files(self, number=-1):
         """Iterate over the files associated with this pull request.
 
@@ -239,15 +221,6 @@ def iter_files(self, number=-1):
         url = self._build_url('files', base_url=self._api)
         return self._iter(int(number), url, PullFile)
 
-    def list_files(self):
-        """List the files associated with this pull request.
-
-        :returns: list of :class:`PullFile <PullFile>`\ s
-        """
-        url = self._build_url('files', base_url=self._api)
-        json = self._json(self._get(url), 200)
-        return [PullFile(f) for f in json]
-
     @requires_auth
     def merge(self, commit_message=''):
         """Merge this pull request.
