8000 maybe fixed discrepancies... · dacoex/pvlib-python@9901538 · GitHub
[go: up one dir, main page]

Skip to content

Commit 9901538

Browse files
committed
maybe fixed discrepancies...
1 parent 55fa894 commit 9901538

File tree

2 files changed

+14
-17
lines changed

2 files changed

+14
-17
lines changed

docs/sphinx/source/package_overview.rst

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ to accomplish our system modeling goal:
6969
energies = {}
7070
for latitude, longitude, name, altitude in coordinates:
7171
system['surface_tilt'] = latitude
72-
cs = pvlib.clearsky.ineichen(times, latitude, longitude)
72+
cs = pvlib.clearsky.ineichen(times, latitude, longitude, altitude=altitude)
7373
solpos = pvlib.solarposition.get_solarposition(times, latitude, longitude)
7474
dni_extra = pvlib.irradiance.extraradiation(times)
7575
dni_extra = pd.Series(dni_extra, index=times)
@@ -137,9 +137,9 @@ objects to accomplish our system modeling goal:
137137
energies = {}
138138
for latitude, longitude, name, altitude in coordinates:
139139
location = Location(latitude, longitude, name=name, altitude=altitude)
140-
# not yet clear what, exactly, goes into ModelChain(s)
140+
# very experimental
141141
mc = ModelChain(system, location,
142-
orientation_strategy='south_at_latitude')
142+
orientation_strategy='south_at_latitude_tilt')
143143
dc, ac = mc.run_model(times)
144144
annual_energy = ac.sum()
145145
energies[name] = annual_energy
@@ -169,21 +169,18 @@ object to accomplish our modeling goal:
169169

170170
.. ipython:: python
171171
172-
from pvlib.pvsystem import PVSystem, LocalizedPVSystem
173-
174-
other_system_params = {} # sometimes helpful to break apart
175-
base_system = PVSystem(module_parameters=module,
176-
inverter_parameters=inverter,
177-
**other_system_params)
172+
from pvlib.pvsystem import LocalizedPVSystem
178173
179174
energies = {}
180175
for latitude, longitude, name, altitude in coordinates:
181-
localized_system = base_system.localize(latitude=latitude,
182-
longitude=longitude,
183-
name=name,
184-
altitude=altitude)
185-
localized_system.surface_tilt = latitude
186-
localized_system.surface_azimuth = 180
176+
localized_system = LocalizedPVSystem(module_parameters=module,
177+
inverter_parameters=inverter,
178+
surface_tilt=latitude,
179+
surface_azimuth=180,
180+
latitude=latitude,
181+
longitude=longitude,
182+
name=name,
183+
altitude=altitude)
187184
clearsky = localized_system.get_clearsky(times)
188185
solar_position = localized_system.get_solarposition(times)
189186
total_irrad = localized_system.get_irradiance(solar_position['apparent_zenith'],

pvlib/modelchain.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class ModelChain(object):
4747
"""
4848

4949
def __init__(self, system, location,
50-
orientation_strategy='south_at_latitude',
50+
orientation_strategy='south_at_latitude_tilt',
5151
clearsky_model='ineichen',
5252
transposition_model='haydavies',
5353
solar_position_method='nrel_numpy',
@@ -73,7 +73,7 @@ def orientation_strategy(self):
7373
def orientation_strategy(self, strategy):
7474
if strategy is None or strategy == 'None':
7575
pass
76-
elif strategy == 'south_at_latitude':
76+
elif strategy == 'south_at_latitude_tilt':
7777
self.system.surface_azimuth = 180
7878
self.system.surface_tilt = self.location.latitude
7979
elif strategy == 'flat':

0 commit comments

Comments
 (0)
0