[Workflow] symfony#24501 Add transition blockers.

d-ph · d-ph · commit 27be4a222355 · 2017-10-29T18:43:02.000Z
diff --git a/src/Symfony/Component/Workflow/Exception/UndefinedTransitionException.php b/src/Symfony/Component/Workflow/Exception/UndefinedTransitionException.php
@@ -14,6 +14,6 @@
 /**
  * Thrown by Workflow when an undefined transition is applied on a subject.
  */
-class UndefinedTransitionException extends SubjectTransitionException
+class UndefinedTransitionException extends LogicException
 {
 }
diff --git a/src/Symfony/Component/Workflow/Workflow.php b/src/Symfony/Component/Workflow/Workflow.php
@@ -142,8 +142,7 @@ public function apply($subject, $transitionName)
 
             if ($transitionBlockerList->findByCode(TransitionBlocker::REASON_CODE_TRANSITION_NOT_DEFINED)) {
                 throw new UndefinedTransitionException(
-                    sprintf('Transition "%s" is not defined in workflow "%s".', $transitionName, $this->name),
-                    $transitionBlockerList
+                    sprintf('Transition "%s" is not defined in workflow "%s".', $transitionName, $this->name)
                 );
             }
 

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,6 @@`
`14`	`14`	`/**`
`15`	`15`	`* Thrown by Workflow when an undefined transition is applied on a subject.`
`16`	`16`	`*/`
`17`		`-class UndefinedTransitionException extends SubjectTransitionException`
	`17`	`+class UndefinedTransitionException extends LogicException`
`18`	`18`	`{`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,7 @@ public function apply($subject, $transitionName)`
`142`	`142`
`143`	`143`	`if ($transitionBlockerList->findByCode(TransitionBlocker::REASON_CODE_TRANSITION_NOT_DEFINED)) {`
`144`	`144`	`throw new UndefinedTransitionException(`
`145`		`- sprintf('Transition "%s" is not defined in workflow "%s".', $transitionName, $this->name),`
`146`		`- $transitionBlockerList`
	`145`	`+ sprintf('Transition "%s" is not defined in workflow "%s".', $transitionName, $this->name)`
`147`	`146`	`);`
`148`	`147`	`}`
`149`	`148`