Improve exception handling: Properly raise IntegrityError exceptions

amotl · amotl · commit 8c39426cd6f2 · 2023-09-28T15:39:29.000+02:00
... when receiving `DuplicateKeyException` errors from CrateDB.
diff --git a/src/crate/client/http.py b/src/crate/client/http.py
@@ -56,6 +56,7 @@
     BlobLocationNotFoundException,
     DigestNotFoundException,
     ProgrammingError,
+    IntegrityError,
 )
 
 
@@ -191,6 +192,18 @@ def _ex_to_message(ex):
 
 
 def _raise_for_status(response):
+    """
+    Properly raise `IntegrityError` exceptions for CrateDB's `DuplicateKeyException` errors.
+    """
+    try:
+        return _raise_for_status_real(response)
+    except ProgrammingError as ex:
+        if "DuplicateKeyException" in ex.message:
+            raise IntegrityError(ex.message, error_trace=ex.error_trace) from ex
+        raise
+
+
+def _raise_for_status_real(response):
     """ make sure that only crate.exceptions are raised that are defined in
     the DB-API specification """
     message = ''
