find the oldest complete

cqkh42 · cqkh42 · commit 43ecce4dd28c · 2020-05-29T14:39:40.000+01:00
diff --git a/findTheOldest/findTheOldest.js b/findTheOldest/findTheOldest.js
@@ -1,5 +1,7 @@
-let findTheOldest = function() {
-
+let findTheOldest = function(object) {
+  const year = new Date().getFullYear()
+  object.sort((a, b) => (a.yearOfDeath || year) - (a.yearOfBirth || year) > (b.yearOfDeath || year) - (b.yearOfBirth || year) ? -1 : 1)
+  return object[0]
 }
 
 module.exports = findTheOldest
diff --git a/findTheOldest/findTheOldest.spec.js b/findTheOldest/findTheOldest.spec.js
@@ -21,7 +21,7 @@ describe('findTheOldest', function() {
     ]
     expect(findTheOldest(people).name).toEqual('Ray');
   });
-  xit('finds the oldest person if someone is still living', function() {
+  it('finds the oldest person if someone is still living', function() {
     const people = [
       {
         name: 'Carly',
@@ -40,7 +40,7 @@ describe('findTheOldest', function() {
     ]
     expect(findTheOldest(people).name).toEqual('Ray');
   });
-  xit('finds the oldest person if the OLDEST is still living', function() {
+  it('finds the oldest person if the OLDEST is still living', function() {
     const people = [
       {
         name: 'Carly',

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
`1`		`-let findTheOldest = function() {`
`2`		`-`
	`1`	`+let findTheOldest = function(object) {`
	`2`	`+ const year = new Date().getFullYear()`
	`3`	`+ object.sort((a, b) => (a.yearOfDeath \|\| year) - (a.yearOfBirth \|\| year) > (b.yearOfDeath \|\| year) - (b.yearOfBirth \|\| year) ? -1 : 1)`
	`4`	`+ return object[0]`
`3`	`5`	`}`
`4`	`6`
`5`	`7`	`module.exports = findTheOldest`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ describe('findTheOldest', function() {`
`21`	`21`	`]`
`22`	`22`	`expect(findTheOldest(people).name).toEqual('Ray');`
`23`	`23`	`});`
`24`		`- xit('finds the oldest person if someone is still living', function() {`
	`24`	`+ it('finds the oldest person if someone is still living', function() {`
`25`	`25`	`const people = [`
`26`	`26`	`{`
`27`	`27`	`name: 'Carly',`
`@@ -40,7 +40,7 @@ describe('findTheOldest', function() {`
`40`	`40`	`]`
`41`	`41`	`expect(findTheOldest(people).name).toEqual('Ray');`
`42`	`42`	`});`
`43`		`- xit('finds the oldest person if the OLDEST is still living', function() {`
	`43`	`+ it('finds the oldest person if the OLDEST is still living', function() {`
`44`	`44`	`const people = [`
`45`	`45`	`{`
`46`	`46`	`name: 'Carly',`