-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/auth): Decouple store from auth module #21405
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
return c | ||
} | ||
|
||
// WithNewGasMeter returns a Context with a newly created transaction GasMeter. | ||
func (c Context) WithNewGasMeter(gaslimit storetypes.Gas) Context { | ||
c.gasMeter = storetypes.NewGasMeter(gaslimit) | ||
return c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change potentially affects state.
Call sequence:
(github.com/cosmos/cosmos-sdk/types.Context).WithBlockGasMeter (types/context.go:224)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).PrepareProposal (types/context.go:393)
@@ -38,6 +38,7 @@ type Meter interface { | |||
Consume(amount Gas, descriptor string) error | |||
Refund(amount Gas, descriptor string) error | |||
Remaining() Gas | |||
Consumed() Gas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should avoid adding this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thinks return remaining in consumed is not corect since remaining implied limit - consumed
but we need to get the consumed amount only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#21440 & #21440 (comment) :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in stf implementation too
cosmos-sdk/server/v2/stf/gas/meter.go
Line 24 in 355f4d7
func (m *Meter) Consumed() gas.Gas { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i was plugging SDKGasMeter in the test and got weird output
gm: gm, | ||
} | ||
} | ||
|
||
func (gm SDKGasMeter) GasConsumed() storetypes.Gas { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tac0turtle this is where i think we need a consumed API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not move this to core, auth could have its own expected interface that store/(v2) implements
@@ -220,6 +220,18 @@ func (c Context) WithGasMeter(meter storetypes.GasMeter) Context { | |||
return c | |||
} | |||
|
|||
// WithNewGasMeter returns a Context with a newly created transaction GasMeter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho we shouldn't add anything to sdk.Context. We want to move away from it.
@@ -16,6 +16,14 @@ func NewKVStoreService(storeKey *storetypes.KVStoreKey) store.KVStoreService { | |||
return &kvStoreService{key: storeKey} | |||
} | |||
|
|||
func NewKVStoreKey(name string) *storetypes.KVStoreKey { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? Shouldn't we use the mock kvstore service from core/testing in tests? Plus that removes no dependencies, it just makes it indirect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i can move some of the core test stuff from Marko PR in to remove the use of storekey
) | ||
|
||
// Wrapper errors for store/v1 ErrorOutOfGas, ErrorNegativeGasConsumed and ErrorGasOverflow so that | ||
// modules don't have to import storev1 directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather have module import store tan the SDK tbh (my t.wo cents)
Can we avoid adding stuff in the SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmmm if we use stf gas implementation then we can avoid import storetypes ErrorOutOfGas all together (so i dont have to wrapped it here). But then we need to add a wrapper for the legacy sdkCtx gas meter, the problem is that the wrapper is in runtime
Description
ref: #21183
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...