fix: dont throw when an inverse relation doesnt exist (js-data#480)

mattlewis92 · crobinson42 · commit d4493a511018 · 2018-06-22T15:29:52.000-07:00
diff --git a/src/DataStore.js b/src/DataStore.js
@@ -178,7 +178,7 @@ const props = {
           const inverseDef = def.getInverse(mapper)
           const currentParentId = currentParent ? utils.get(currentParent, def.getRelation().idAttribute) : undefined
 
-          if (currentParent && currentParentId !== undefined && currentParentId !== value) {
+          if (inverseDef && currentParent && currentParentId !== undefined && currentParentId !== value) {
             if (inverseDef.type === hasOneType) {
               safeSetLink(currentParent, inverseDef.localField, undefined)
             } else if (inverseDef.type === hasManyType) {
diff --git a/test/unit/collection/add.test.js b/test/unit/collection/add.test.js
@@ -298,4 +298,27 @@ describe('Collection#add', function () {
     // console.log('\tinject 10,000 users time taken: ', new Date().getTime() - start, 'ms')
     // console.log('\tusers age 40-44', User.between(40, 45, { index: 'age' }).length)
   })
+  it('should update a records relation when the inverse relation does not exist', function () {
+    const store = new JSData.DataStore()
+    store.defineMapper('user')
+    store.defineMapper('post', {
+      relations: {
+        belongsTo: {
+          user: {
+            localKey: 'user_id',
+            localField: 'user'
+          }
+        }
+      }
+    })
+    const [user1, user2] = store.add('user', [{
+      id: 1, name: 'John'
+    }, {
+      id: 2, name: 'Jane'
+    }])
+    const post = store.add('post', { id: 2, title: 'foo', user_id: 1 })
+    assert.strictEqual(post.user, user1)
+    store.add('post', { id: 2, title: 'foo', user_id: 2 })
+    assert.strictEqual(post.user, user2)
+  })
 })
