fix(Collection): 'get' to return undefined when item id is not provided (js-data#457)

ivanvoznyakovsky · jmdobry · commit c109e573fbd1 · 2017-04-24T12:25:50.000-07:00
diff --git a/src/Collection.js b/src/Collection.js
@@ -511,7 +511,7 @@ export default Component.extend({
    * @returns {(Object|Record)} The record with the given id.
    */
   get (id) {
-    const instances = this.query().get(id).run()
+    const instances = id === undefined ? [] : this.query().get(id).run()
     return instances.length ? instances[0] : undefined
   },
 
diff --git a/test/unit/collection/get.test.js b/test/unit/collection/get.test.js
@@ -5,5 +5,6 @@ describe('Collection#get', function () {
     const user = this.UserCollection.add({ id: 1 })
     assert(this.UserCollection.get(1) === user, 'should get the user from the collection')
     assert(!this.UserCollection.get(2), 'should return undefined if the item is not in the collection')
+    assert(!this.UserCollection.get(), 'should return undefined if item id is not provided')
   })
 })
