8000 refactor: fix eslint warnings · coreui/coreui-vue@72f1a61 · GitHub
[go: up one dir, main page]
Skip to content

Commit 72f1a61

Browse files
mrholekmrholek
committed
refactor: fix eslint warnings
1 parent d8b03cf commit 72f1a61

File tree

7 files changed

+20
-10
lines changed

7 files changed

+20
-10
lines changed

‎packages/coreui-vue/src/components/dropdown/CDropdown.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,22 @@ const CDropdown = defineComponent({
1919
if (value === 'start' || value === 'end') {
2020
return true
2121
} else {
22-
if (typeof value.xs !== 'undefined' && (value.xs === 'start' || value.xs === 'end')) {
22+
if (value.xs !== undefined && (value.xs === 'start' || value.xs === 'end')) {
2323
return true
2424
}
25-
if (typeof value.sm !== 'undefined' && (value.sm === 'start' || value.sm === 'end')) {
25+
if (value.sm !== undefined && (value.sm === 'start' || value.sm === 'end')) {
2626
return true
2727
}
28-
if (typeof value.md !== 'undefined' && (value.md === 'start' || value.md === 'end')) {
28+
if (value.md !== undefined && (value.md === 'start' || value.md === 'end')) {
2929
return true
3030
}
31-
if (typeof value.lg !== 'undefined' && (value.lg === 'start' || value.lg === 'end')) {
31+
if (value.lg !== undefined && (value.lg === 'start' || value.lg === 'end')) {
3232
return true
3333
}
34-
if (typeof value.xl !== 'undefined' && (value.xl === 'start' || value.xl === 'end')) {
34+
if (value.xl !== undefined && (value.xl === 'start' || value.xl === 'end')) {
3535
return true
3636
}
37-
if (typeof value.xxl !== 'undefined' && (value.xxl === 'start' || value.xxl === 'end')) {
37+
if (value.xxl !== undefined && (value.xxl === 'start' || value.xxl === 'end')) {
3838
return true
3939
}
4040
return false

‎packages/coreui-vue/src/components/dropdown/CDropdownMenu.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const CDropdownMenu = defineComponent({
2222

2323
const { autoClose, alignment, dark, popper } = config
2424

25-
// eslint-disable-next-line @typescript-eslint/ban-types
25+
// eslint-disable-next-line @typescript-eslint/ban-types, unicorn/consistent-function-scoping
2626
const alignmentClassNames = (alignment: object | string) => {
2727
const classNames: string[] = []
2828
if (typeof alignment === 'object') {

‎packages/coreui-vue/src/components/nav/CNavGroup.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,19 +63,23 @@ const CNavGroup = defineComponent({
6363
navGroupRef.value.classList.add('show')
6464
}
6565

66+
// eslint-disable-next-line unicorn/consistent-function-scoping
6667
const handleEnter = (el: RendererElement, done: () => void) => {
6768
executeAfterTransition(() => done(), el as HTMLElement)
6869
el.style.height = `${el.scrollHeight}px`
6970
}
7071

72+
// eslint-disable-next-line unicorn/consistent-function-scoping
7173
const handleAfterEnter = (el: RendererElement) => {
7274
el.style.height = 'auto'
7375
}
7476

77+
// eslint-disable-next-line unicorn/consistent-function-scoping
7578
const handleBeforeLeave = (el: RendererElement) => {
7679
el.style.height = `${el.scrollHeight}px`
7780
}
7881

82+
// eslint-disable-next-line unicorn/consistent-function-scoping
7983
const handleLeave = (el: RendererElement, done: () => void) => {
8084
executeAfterTransition(() => done(), el as HTMLElement)
8185
setTimeout(() => {

‎packages/coreui-vue/src/components/navbar/CNavbar.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ const CNavbar = defineComponent({
8585
props.container
8686
? h(
8787
'div',
88-
{ class: [`container${props.container !== true ? '-' + props.container : ''}`] },
88+
{ class: [`container${props.container === true ? '' : '-' + props.container}`] },
8989
slots.default && slots.default(),
9090
)
9191
: slots.default && slots.default(),

‎packages/coreui-vue/src/components/offcanvas/COffcanvas.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,11 +127,13 @@ const COffcanvas = defineComponent({
127127
offcanvasRef.value.focus()
128128
}
129129

130+
// eslint-disable-next-line unicorn/consistent-function-scoping
130131
const handleLeave = (el: RendererElement, done: () => void) => {
131132
executeAfterTransition(() => done(), el as HTMLElement)
132133
el.classList.add('hiding')
133134
}
134135

136+
// eslint-disable-next-line unicorn/consistent-function-scoping
135137
const handleAfterLeave = (el: RendererElement) => {
136138
el.classList.remove('show', 'hiding')
137139
}

‎packages/coreui-vue/src/directives/v-c-popover.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ const createPopoverElement = (id: string, header: string, content: string): HTML
1414
return popover
1515
}
1616

17+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
1718
const addPopoverElement = (popover: HTMLDivElement, el: HTMLElement, popperOptions: any) => {
1819
document.body.appendChild(popover)
1920
createPopper(el, popover, popperOptions)
@@ -25,10 +26,11 @@ const addPopoverElement = (popover: HTMLDivElement, el: HTMLElement, popperOptio
2526
const removePopoverElement = (popover: HTMLDivElement) => {
2627
popover.classList.remove('show')
2728
setTimeout(() => {
28-
document.body.removeChild(popover)
29+
popover.remove()
2930
}, 300)
3031
}
3132

33+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
3234
const togglePopoverElement = (popover: HTMLDivElement, el: HTMLElement, popperOptions: any) => {
3335
const popperElement = document.getElementById(popover.id)
3436
if (popperElement && popperElement.classList.contains('show')) {

‎packages/coreui-vue/src/directives/v-c-tooltip.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ const createTooltipElement = (id: string, content: string): HTMLDivElement => {
1313
return tooltip
1414
}
1515

16+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
1617
const addTooltipElement = (tooltip: HTMLDivElement, el: HTMLElement, popperOptions: any) => {
1718
document.body.appendChild(tooltip)
1819
createPopper(el, tooltip, popperOptions)
@@ -24,10 +25,11 @@ const addTooltipElement = (tooltip: HTMLDivElement, el: HTMLElement, popperOptio
2425
const removeTooltipElement = (tooltip: HTMLDivElement) => {
2526
tooltip.classList.remove('show')
2627
setTimeout(() => {
27-
document.body.removeChild(tooltip)
28+
tooltip.remove()
2829
}, 300)
2930
}
3031

32+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
3133
const toggleTooltipElement = (tooltip: HTMLDivElement, el: HTMLElement, popperOptions: any) => {
3234
const popperElement = document.getElementById(tooltip.id)
3335
if (popperElement && popperElement.classList.contains('show')) {

0 commit comments

Comments
 (0)
0