8000 refactor: improve LTR and RTL direction handling · coreui/coreui@7f183e3 · GitHub
[go: up one dir, main page]

Skip to content

Commit 7f183e3

Browse files
committed
refactor: improve LTR and RTL direction handling
1 parent 5745b12 commit 7f183e3

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

scss/sidebar/_sidebar-narrow.scss

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@
33
--#{$prefix}sidebar-narrow-width: #{$sidebar-narrow-width};
44
// scss-docs-end sidebar-narrow-css-vars
55

6-
.sidebar-nav {
7-
--#{$prefix}sidebar-nav-link-padding-x: #{$sidebar-narrow-nav-link-padding-x};
8-
--#{$prefix}sidebar-nav-link-padding-y: #{$sidebar-narrow-nav-link-padding-y};
9-
}
10-
116
@include media-breakpoint-up($mobile-breakpoint) {
127
flex: 0 0 var(--#{$prefix}sidebar-narrow-width);
138
width: var(--#{$prefix}sidebar-narrow-width);
@@ -32,6 +27,11 @@
3227
padding-left: 0;
3328
}
3429

30+
.sidebar-nav {
31+
--#{$prefix}sidebar-nav-link-padding-x: #{$sidebar-narrow-nav-link-padding-x};
32+
--#{$prefix}sidebar-nav-link-padding-y: #{$sidebar-narrow-nav-link-padding-y};
33+
}
34+
3535
.nav-icon {
3636
flex: 0 0 calc(var(--#{$prefix}sidebar-narrow-width) - (var(--#{$prefix}sidebar-nav-padding-x) * 2) - (var(--#{$prefix}sidebar-nav-link-padding-x) * 2)); // stylelint-disable-line function-disallowed-list
3737
}
@@ -49,7 +49,7 @@
4949
opacity: 0;
5050
}
5151

52-
.sidebar-toggler {
52+
.sidebar-toggler::before {
5353
@include ltr-rtl("transform", rotate(-180deg), null, rotate(0deg));
5454
}
5555

@@ -90,11 +90,11 @@
9090
&:hover {
9191
box-shadow: $box-shadow;
9292

93-
.sidebar-toggler {
93+
.sidebar-toggler::before {
9494
@include ltr-rtl("transform", rotate(-180deg), null, rotate(0deg));
9595
}
9696

97-
&.sidebar-end .sidebar-toggler {
97+
&.sidebar-end .sidebar-toggler::before {
9898
transform: rotate(0deg);
9999
}
100100
}

scss/sidebar/_sidebar.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,6 @@
229229
background-color: transparent;
230230
border: 0;
231231
@include border-radius();
232-
@include transition(var(--#{$prefix}sidebar-toggler-transition));
233232

234233
&::before {
235234
position: absolute;
@@ -240,6 +239,10 @@
240239
content: "";
241240
background-color: var(--#{$prefix}sidebar-toggler-color);
242241
mask: var(--#{$prefix}sidebar-toggler-bg) no-repeat center;
242+
@include transition(var(--#{$prefix}sidebar-toggler-transition));
243+
@include rtl() {
244+
transform: rotate(-180deg);
245+
}
243246
}
244247

245248
// Override <a>'s hover style

0 commit comments

Comments
 (0)
0