Merge pull request encode#708 from kevinastone/master

tomchristie · tomchristie · commit f5a8f172a32f · 2013-03-07T01:01:07.000-08:00
Fixed DateField with Empty Values (Fixes encode#707)
diff --git a/rest_framework/fields.py b/rest_framework/fields.py
@@ -534,6 +534,8 @@ def from_native(self, value):
         raise ValidationError(msg)
 
     def to_native(self, value):
+        if value is None:
+            return None
         if isinstance(value, datetime.datetime):
             value = value.date()
         if self.format.lower() == ISO_8601:
@@ -599,6 +601,8 @@ def from_native(self, value):
         raise ValidationError(msg)
 
     def to_native(self, value):
+        if value is None:
+            return None
         if self.format.lower() == ISO_8601:
             return value.isoformat()
         return value.strftime(self.format)
diff --git a/rest_framework/tests/fields.py b/rest_framework/tests/fields.py
@@ -171,6 +171,13 @@ def test_to_native_custom_format(self):
 
         self.assertEqual('1984 - 07.31', result_1)
 
+    def test_to_native_none(self):
+        """
+        Make sure from_native() returns None on None param.
+        """
+        f = serializers.DateField(required=False)
+        self.assertEqual(None, f.to_native(None))
+
 
 class DateTimeFieldTest(TestCase):
     """
@@ -303,6 +310,13 @@ def test_to_native_custom_format(self):
         self.assertEqual('1984 - 04:31', result_3)
         self.assertEqual('1984 - 04:31', result_4)
 
+    def test_to_native_none(self):
+        """
+        Make sure from_native() returns None on None param.
+        """
+        f = serializers.DateTimeField(required=False)
+        self.assertEqual(None, f.to_native(None))
+
 
 class TimeFieldTest(TestCase):
     """
